Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build with --shared-openssl configure option #7583

Closed
AdamMajer opened this issue Jul 7, 2016 · 2 comments
Closed

Fails to build with --shared-openssl configure option #7583

AdamMajer opened this issue Jul 7, 2016 · 2 comments
Labels
build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol openssl Issues and PRs related to the OpenSSL dependency.

Comments

@AdamMajer
Copy link
Contributor

AdamMajer commented Jul 7, 2016 •
edited
Loading

  • Version: 6.3.0
  • Platform: OpenSUSE Tumbleweed
  • Subsystem:

With this pull #6792 , NodeJS stopped building when --shared-openssl option is specified. This is not fixed with later commits. Build system is still looking for static SSL library,

make[1]: *** No rule to make target '/home/abuild/rpmbuild/BUILD/node-v6.3.0/out/Release/obj.target/openssl/deps/openssl/openssl/ssl/bio_ssl.o', needed by '/home/abuild/rpmbuild/BUILD/node-v6.3.0/out/Release/obj.target/deps/openssl/libopenssl.a'. Stop.

Workaround is to configure--without-inspector
@ChALkeR
Copy link
Member

ChALkeR commented Jul 7, 2016 •
edited
Loading

Try #7569.
Related: #7478 and #7486.

@ChALkeR ChALkeR added build Issues and PRs related to build files or the CI. openssl Issues and PRs related to the OpenSSL dependency. inspector Issues and PRs related to the V8 inspector protocol labels Jul 7, 2016
@AdamMajer
Copy link
Contributor Author

Thank you @ChALkeR , this PR does fix this issue.

@ChALkeR ChALkeR mentioned this issue Jul 8, 2016
Merged
2 tasks
@ChALkeR ChALkeR closed this as completed in 990c968 Jul 9, 2016
evanlucas pushed a commit that referenced this issue Jul 13, 2016
@ChALkeR @evanlucas
build: respect --shared-* flags for inspector deps
933ff62 
Don't build openssl/http_parser/libuv for v8_inspector if corresponding
--shared-* flags were passed to the ./configure script.

Fixes: #7478
Fixes: #7583
PR-URL: #7569
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. inspector Issues and PRs related to the V8 inspector protocol openssl Issues and PRs related to the OpenSSL dependency.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChALkeR @AdamMajer