-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: fix TODO in tools/icu/README.md #7843
Comments
|
/ping @srl295 There are two TODOs in the icu README. Are either of them addressable at this time? |
also:
|
- remove TODOs: the one about defaults has been addressed, and the one about testing is a work item that doesn't belong in a doc. - add some background information Fixes: nodejs#7843 PR-URL: nodejs#16939 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fix TODO in https://github.com/nodejs/node/blob/master/tools/icu/README.md
small-icu is the default now.
The text was updated successfully, but these errors were encountered: