Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-util-sigint-watchdog on FreeBSD #7919

Closed
Trott opened this issue Jul 30, 2016 · 2 comments
Closed

Investigate flaky test-util-sigint-watchdog on FreeBSD #7919

Trott opened this issue Jul 30, 2016 · 2 comments
Assignees
@addaleax
Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.

Comments

@Trott
Copy link
Member

Trott commented Jul 30, 2016

I've seen this at least twice now, so it's definitely A Thing...

https://ci.nodejs.org/job/node-test-commit-freebsd/3505/nodes=freebsd10-64/console:

not ok 1046 parallel/test-util-sigint-watchdog
# 
# assert.js:89
#   throw new assert.AssertionError({
#   ^
# AssertionError: false === true
#     at Timeout.common.mustCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-util-sigint-watchdog.js:25:12)
#     at Timeout._onTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common.js:411:15)
#     at tryOnTimeout (timers.js:232:11)
#     at Timer.listOnTimeout (timers.js:202:5)

/cc @addaleax
@Trott Trott added util Issues and PRs related to the built-in util module. test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. labels Jul 30, 2016
@addaleax addaleax self-assigned this Jul 30, 2016
@Trott
Copy link
Member Author

Trott commented Aug 1, 2016

Another one (no new info):

https://ci.nodejs.org/job/node-test-commit-freebsd/3518/nodes=freebsd10-64/console

not ok 1048 parallel/test-util-sigint-watchdog
# 
# assert.js:89
#   throw new assert.AssertionError({
#   ^
# AssertionError: false === true
#     at Timeout.common.mustCall (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/parallel/test-util-sigint-watchdog.js:51:12)
#     at Timeout._onTimeout (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd10-64/test/common.js:411:15)
#     at tryOnTimeout (timers.js:232:11)
#     at Timer.listOnTimeout (timers.js:202:5)
  ---
  duration_ms: 0.644

Trott added a commit to Trott/io.js that referenced this issue Aug 1, 2016
@Trott
test: mark test-util-sigint-watchdog FreeBSD flaky
e212f6b 
Refs: nodejs#7919
@Trott Trott mentioned this issue Aug 1, 2016
Closed
2 tasks
addaleax added a commit to addaleax/node that referenced this issue Aug 1, 2016
@addaleax
test,util: fix flaky test-util-sigint-watchdog
36aa89b 
Fix parallel/test-util-sigint-watchdog by polling until the
signal has definitely been received instead of just using a timeout.

Fixes: nodejs#7919
@addaleax addaleax mentioned this issue Aug 1, 2016
Closed
3 tasks
@addaleax
Copy link
Member

addaleax commented Aug 1, 2016

Proposed fix: #7933

addaleax added a commit that referenced this issue Aug 11, 2016
@addaleax
test,util: fix flaky test-util-sigint-watchdog
6d3241d 
Fix parallel/test-util-sigint-watchdog by polling until the
signal has definitely been received instead of just using a timeout.

Fixes: #7919
PR-URL: #7933
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig pushed a commit that referenced this issue Aug 11, 2016
@addaleax @cjihrig
test,util: fix flaky test-util-sigint-watchdog
4416ffa 
Fix parallel/test-util-sigint-watchdog by polling until the
signal has definitely been received instead of just using a timeout.

Fixes: #7919
PR-URL: #7933
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addaleax addaleax

Labels
freebsd Issues and PRs related to the FreeBSD platform. test Issues and PRs related to the tests. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test,vm: fix flaky test-util-sigint-watchdog addaleax/node
2 participants
@Trott @addaleax