Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIX: parallel/test-cluster-dgram-1 failures #8380

Closed
mhdawson opened this issue Sep 2, 2016 · 11 comments
Closed

AIX: parallel/test-cluster-dgram-1 failures #8380

mhdawson opened this issue Sep 2, 2016 · 11 comments
Labels
cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 2, 2016

  • Version: master
  • Platform: AIX
  • Subsystem: cluster
    This test seems to have started failing recently:
not ok 112 parallel/test-cluster-dgram-1
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
#     at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
#     at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
#     at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
# Mismatched <anonymous> function calls. Expected 1, actual 0.
#     at setupWorker (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:69:36)
#     at master (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:59:7)
#     at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-aix/nodes/aix61-ppc64/test/parallel/test-cluster-dgram-1.js:18:3)
#     at Module._compile (module.js:556:32)
#     at Object.Module._extensions..js (module.js:565:10)
#     at Module.load (module.js:473:32)
#     at tryModuleLoad (module.js:432:12)
#     at Function.Module._load (module.js:424:3)
#     at Module.runMain (module.js:590:10)
  ---
  duration_ms: 0.833
  ...
@mhdawson mhdawson added the test Issues and PRs related to the tests. label Sep 2, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016

May be related to this refactoring: #8261 which landed recently.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016

@jasnell. Opened issue to cover and has info printed from last failure.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016

Can we either revert the refactor of this specific test case until we can figure out the right way to go ?

@mhdawson mhdawson mentioned this issue Sep 2, 2016
Closed
3 tasks
santigimeno added a commit to santigimeno/node that referenced this issue Sep 2, 2016
@santigimeno
test: fix test-cluster-dgram-1 flakiness
a7a788b 
Check for the number of messages received in the `exit` event listener
instead of the `disconnect` listener.

Fixes: nodejs#8380
@santigimeno santigimeno mentioned this issue Sep 2, 2016
Closed
2 tasks
@santigimeno
Copy link
Member

#8383 fixes the issue for me in FreeBSD.

@jasnell
Copy link
Member

jasnell commented Sep 2, 2016

@mhdawson ... can you test if #8383 fixes the issue on AIX. If it does not, then reverting the change for this one test is just fine.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016

Ok starting tests now.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016 •
edited
Loading

Tested results are in #8383

Net is that is helps but I still see failure 3/150 versus 0 with the old version.

@jasnell
Copy link
Member

jasnell commented Sep 2, 2016

Ok, let's revert this one then. I'll get the PR together for that shortly.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016

PR to revert that one test if we decide its the right way to go: https://github.com/nodejs/node/pull/8384/files

@mhdawson
Copy link
Member Author

mhdawson commented Sep 2, 2016

Ok updated fix in #8383 resolves the issues. :)

@jasnell
Copy link
Member

jasnell commented Sep 2, 2016

It looks like the failure here may have been happening before the refactor but just hadn't been caught. Adding the common.mustCall() added the additional constraint that highlighted the flaky failure. I'd say that's a win ;-) Thanks for looking into it @mhdawson

@mscdex mscdex added cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. labels Sep 2, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Sep 8, 2016
@santigimeno @Fishrock123
test: fix test-cluster-dgram-1 flakiness
c8a9649 
Check for the number of messages received in the `exit` event listener
instead of the `disconnect` listener.

Fixes: nodejs#8380
PR-URL: nodejs#8383
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed By: James M Snell <jasnell@gmail.com>
Fishrock123 pushed a commit that referenced this issue Sep 9, 2016
@santigimeno @Fishrock123
test: fix test-cluster-dgram-1 flakiness
f0300ed 
Check for the number of messages received in the `exit` event listener
instead of the `disconnect` listener.

Fixes: #8380
PR-URL: #8383
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed By: James M Snell <jasnell@gmail.com>
@santigimeno santigimeno mentioned this issue Oct 15, 2016
Closed
4 tasks
santigimeno added a commit to santigimeno/node that referenced this issue Oct 15, 2016
@santigimeno
test: fix test-cluster-dgram-1 flakiness
652493c 
Check for the number of messages received in the `exit` event listener
instead of the `disconnect` listener.

Fixes: nodejs#8380
Ref: nodejs#8383
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 24, 2016
@santigimeno @MylesBorins
test: fix test-cluster-dgram-1 flakiness
ecf8f5a 
Check for the number of messages received in the `exit` event listener
instead of the `disconnect` listener.

Fixes: #8380
Ref: #8383
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this issue Oct 26, 2016
@santigimeno @MylesBorins
test: fix test-cluster-dgram-1 flakiness
d5f03db 
Check for the number of messages received in the `exit` event listener
instead of the `disconnect` listener.

Fixes: #8380
Ref: #8383
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix test-cluster-dgram-1 flakiness santigimeno/node
4 participants
@mscdex @jasnell @santigimeno @mhdawson