Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-npm-install failing on freebsd 10/11 #9074

Closed
Trott opened this issue Oct 13, 2016 · 3 comments
Closed

test-npm-install failing on freebsd 10/11 #9074

Trott opened this issue Oct 13, 2016 · 3 comments
Labels
freebsd Issues and PRs related to the FreeBSD platform. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Oct 13, 2016

test-npm-install is currently failing consistently on freebsd11-x64 in CI.

Example failure: https://ci.nodejs.org/job/node-test-commit-freebsd/4792/nodes=freebsd11-x64/console

not ok 737 parallel/test-npm-install
# 
# assert.js:85
#   throw new assert.AssertionError({
#   ^
# AssertionError: npm install should run without an error
#     at ChildProcess.handleExit (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/parallel/test-npm-install.js:48:10)
#     at ChildProcess.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/common.js:422:15)
#     at emitTwo (events.js:106:13)
#     at ChildProcess.emit (events.js:191:7)
#     at Process.ChildProcess._handle.onexit (internal/child_process.js:215:12)
  ---
  duration_ms: 2.45

/cc @thealphanerd @nodejs/testing

@Trott Trott added test Issues and PRs related to the tests. freebsd Issues and PRs related to the FreeBSD platform. npm Issues and PRs related to the npm client dependency or the npm registry. labels Oct 13, 2016
@Trott
Copy link
Member Author

Trott commented Oct 13, 2016

It's a permissions issue.

[iojs@test-digitalocean-freebsd11-x64-1 ~/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/tmp]$ ../../node ../../deps/npm/bin/npm-cli.js install
npm ERR! tar.pack Could not write /home/iojs/.npm/package-name/1.2.3/package.tgz
npm ERR! addLocalDirectory Could not pack /home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/fixtures/packages/main to /home/iojs/.npm/package-name/1.2.3/package.tgz
npm ERR! addLocal Could not install /home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/fixtures/packages/main
npm ERR! FreeBSD 11.0-RELEASE-p1
npm ERR! argv "/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/out/Release/node" "/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/deps/npm/bin/npm-cli.js" "install"
npm ERR! node v7.0.0-pre
npm ERR! npm  v3.10.8
npm ERR! path /home/iojs/.npm/package-name/1.2.3/package.tgz.4069004711
npm ERR! code EACCES
npm ERR! errno -13
npm ERR! syscall open

npm ERR! Error: EACCES: permission denied, open '/home/iojs/.npm/package-name/1.2.3/package.tgz.4069004711'
npm ERR!  { Error: EACCES: permission denied, open '/home/iojs/.npm/package-name/1.2.3/package.tgz.4069004711'
npm ERR!   errno: -13,
npm ERR!   code: 'EACCES',
npm ERR!   syscall: 'open',
npm ERR!   path: '/home/iojs/.npm/package-name/1.2.3/package.tgz.4069004711' }
npm ERR! 
npm ERR! Please try running this command again as root/Administrator.

npm ERR! Please include the following file with any support request:
npm ERR!     /usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/tmp/npm-debug.log
[iojs@test-digitalocean-freebsd11-x64-1 ~/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/tmp]$

joaocgreis added a commit to JaneaSystems/node that referenced this issue Oct 13, 2016
npm should run in a sandbox to avoid unwanted interactions. Without
this change, npm would read the userconfig file $HOME/.npmrc which may
contain configs that break this test.

Fixes: nodejs#9074
@joaocgreis
Copy link
Member

Proposed solution: #9079

@jbergstroem jbergstroem changed the title test-npm-install failing on freebsd11-x64 test-npm-install failing on freebsd 10/11 Oct 13, 2016
@jbergstroem
Copy link
Member

The problem was that jenkins slave ran as root prior. I've adjusted permissions but I'd still like to see #9079 land.

jasnell pushed a commit that referenced this issue Oct 17, 2016
npm should run in a sandbox to avoid unwanted interactions. Without
this change, npm would read the userconfig file $HOME/.npmrc which may
contain configs that break this test.

Fixes: #9074
PR-URL: #9079
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 11, 2016
npm should run in a sandbox to avoid unwanted interactions. Without
this change, npm would read the userconfig file $HOME/.npmrc which may
contain configs that break this test.

Fixes: #9074
PR-URL: #9079
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue Nov 11, 2016
npm should run in a sandbox to avoid unwanted interactions. Without
this change, npm would read the userconfig file $HOME/.npmrc which may
contain configs that break this test.

Fixes: #9074
PR-URL: #9079
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
freebsd Issues and PRs related to the FreeBSD platform. npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

3 participants