Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: updated test-domain-exit-dispose-again #10003

Closed
wants to merge 1 commit into from
Closed

test: updated test-domain-exit-dispose-again #10003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/parallel/test-domain-exit-dispose-again.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ setTimeout(function firstTimer() {
'a domain that should be disposed.');
disposalFailed = true;
process.exit(1);
});
}, TIMEOUT_DURATION);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be 1 instead of TIMEOUT_DURATION.


// Make V8 throw an unreferenced error. As a result, the domain's error
// handler is called, which disposes the domain "d" and should prevent the
Expand All @@ -69,8 +69,8 @@ setTimeout(function secondTimer() {
}, TIMEOUT_DURATION);

process.on('exit', function() {
assert.equal(a, 10);
assert.equal(disposalFailed, false);
assert.strictEqual(a, 10);
assert.strictEqual(disposalFailed, false);
assert(secondTimerRan);
console.log('ok');
});