url, test: add inspect to TupleOrigin #10039

captainsafia · 2016-12-01T17:54:21Z

Checklist

make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

url, test

Description of change

This PR adds code and tests for an inspect function on the TupleOrigin object.

This adds a simple inspect function the the TupleOrigin class.

This adds tests for the newly added inspect function in the TupleOrigin class.

Trott · 2016-12-02T04:57:27Z

/cc @jasnell @addaleax

addaleax

LGTM with a suggestion, thanks!

addaleax · 2016-12-02T14:29:36Z

lib/internal/url.js

@@ -69,6 +69,15 @@ class TupleOrigin {
      result += `:${this.port}`;
    return result;
  }
+
+  inspect() {
+    return `TupleOrigin{


I think we have spaces before the { in most cases here?

cjihrig

LGTM with @addaleax's nit addressed and a CI run.

jasnell · 2016-12-02T17:24:49Z

Lgtm

…

On Fri, Dec 2, 2016 at 11:19 AM Colin Ihrig ***@***.***> wrote: ***@***.**** approved this pull request. LGTM with @addaleax <https://github.com/addaleax>'s nit addressed and a CI run. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10039 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2ecmm-yrL9WiUggst-DNXQrt8VTw_ks5rEFMMgaJpZM4LBsld> .

captainsafia · 2016-12-02T18:38:11Z

Nit addressed.

gibfahn · 2016-12-02T20:12:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/5122/

addaleax · 2016-12-02T22:50:25Z

@captainsafia Looks like you need to update the test files too? :)

addaleax · 2016-12-02T23:13:00Z

Thanks for being so quick to update! Here’s a new CI: https://ci.nodejs.org/job/node-test-commit/6348/

captainsafia · 2016-12-02T23:13:14Z

@addaleax: Whoops. Excuse my merge-eager fingers. Fixed now. 😊

addaleax · 2016-12-05T02:14:25Z

Landed in 8831732, thanks for the contribution!

This adds a simple inspect function the the TupleOrigin class. This adds tests for the newly added inspect function in the TupleOrigin class. PR-URL: #10039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

jasnell · 2016-12-05T02:41:28Z

Thank you for this @captainsafia ... this one has been on my list of todo's for remaining items on the new URL implementation and I really appreciate the contribution!

This adds a simple inspect function the the TupleOrigin class. This adds tests for the newly added inspect function in the TupleOrigin class. PR-URL: nodejs#10039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

This adds a simple inspect function the the TupleOrigin class. This adds tests for the newly added inspect function in the TupleOrigin class. PR-URL: #10039 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>

Notable changes SEMVER-MINOR - url: - add inspect function to TupleOrigin (Safia Abdalla) #10039 - crypto: - allow adding extra certs to well-known CAs (Sam Roberts) #9139 SEMVER-PATCH - buffer: - fix single-character string filling (Anna Henningsen) #9837 - handle UCS2 .fill() properly on BE (Anna Henningsen) #9837 - url: - including base argument in originFor (joyeecheung) #10021 - improve URLSearchParams spec compliance (Timothy Gu) #9484 - http: - remove stale timeout listeners (Karl Böhlmark) #9440 - build: - fix node_g target (Daniel Bevenius) #10153 - fs: - remove unused argument from copyObject() (Ethan Arrowood) #10041 - timers: - fix handling of cleared immediates (hveldstra) #9759 PR-URL: #10277

Notable changes: * **crypto**: - Allow adding extra certificates to well-known CAs. (Sam Roberts) [#9139](#9139) * **buffer**: - Fix single-character string filling. (Anna Henningsen) [#9837](#9837) - Handle UCS2 `.fill()` properly on BE. (Anna Henningsen) [#9837](#9837) * **url**: - Add inspect function to TupleOrigin. (Safia Abdalla) [#10039](#10039) - Including base argument in originFor. (joyeecheung) [#10021](#10021) - Improve URLSearchParams spec compliance. (Timothy Gu) [#9484](#9484) * **http**: - Remove stale timeout listeners. (Karl Böhlmark) [#9440](#9440) * **build**: - Fix node_g target. (Daniel Bevenius) [#10153](#10153) * **fs**: - Remove unused argument from copyObject(). (EthanArrowood) [#10041](#10041) * **timers**: - Fix handling of cleared immediates. (hveldstra) [#9759](#9759) * **src**: - Add wrapper for process.emitWarning(). (SamRoberts) [#9139](#9139) - Fix string format mistake for 32 bit node.(Alex Newman) [#10082](#10082)

captainsafia added 2 commits December 1, 2016 11:23

url: add inspect function to TupleOrigin

c6b324e

This adds a simple inspect function the the TupleOrigin class.

test: add test for inspect in TupleOrigin

b930653

This adds tests for the newly added inspect function in the TupleOrigin class.

nodejs-github-bot added the url Issues and PRs related to the legacy built-in url module. label Dec 1, 2016

captainsafia changed the title ~~url, test: add inspect to tuple origin~~ url, test: add inspect to TupleOrigin Dec 1, 2016

imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016

Trott added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 2, 2016

addaleax approved these changes Dec 2, 2016

View reviewed changes

cjihrig approved these changes Dec 2, 2016

View reviewed changes

url: fix spacing in inspect string

d2a35cb

gibfahn approved these changes Dec 2, 2016

View reviewed changes

test: update tests to match new format

79a9b53

addaleax closed this Dec 5, 2016

addaleax added dont-land-on-v4.x labels Dec 5, 2016

captainsafia deleted the add-inspect-to-tuple-origin branch December 5, 2016 07:09

italoacasas mentioned this pull request Dec 15, 2016

v7.3.0 proposal #10277

Merged

joyeecheung added the whatwg-url Issues and PRs related to the WHATWG URL implementation. label Jan 5, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

url, test: add inspect to TupleOrigin #10039

url, test: add inspect to TupleOrigin #10039

captainsafia commented Dec 1, 2016

Trott commented Dec 2, 2016

addaleax left a comment •

edited

Loading

addaleax Dec 2, 2016

cjihrig left a comment

jasnell commented Dec 2, 2016 via email

captainsafia commented Dec 2, 2016

gibfahn commented Dec 2, 2016

addaleax commented Dec 2, 2016

addaleax commented Dec 2, 2016

captainsafia commented Dec 2, 2016

addaleax commented Dec 5, 2016

jasnell commented Dec 5, 2016

url, test: add inspect to TupleOrigin #10039

url, test: add inspect to TupleOrigin #10039

Conversation

captainsafia commented Dec 1, 2016

Checklist

Affected core subsystem(s)

Description of change

Trott commented Dec 2, 2016

addaleax left a comment • edited Loading

Choose a reason for hiding this comment

addaleax Dec 2, 2016

Choose a reason for hiding this comment

cjihrig left a comment

Choose a reason for hiding this comment

jasnell commented Dec 2, 2016 via email

captainsafia commented Dec 2, 2016

gibfahn commented Dec 2, 2016

addaleax commented Dec 2, 2016

addaleax commented Dec 2, 2016

captainsafia commented Dec 2, 2016

addaleax commented Dec 5, 2016

jasnell commented Dec 5, 2016

addaleax left a comment •

edited

Loading