test: refactor test-pipe-file-to-http #10054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imyller
added
code-and-learn
cjihrig
requested changes
Dec 3, 2016
| s.pipe(req); | ||
| s.on('close', function(err) { | ||
| s.on('close', common.mustCall((err) => { | ||
| if (err) throw err; | ||
| clientReqComplete = true; |
There was a problem hiding this comment.
Because this is now in a common.mustCall(), you should be able to remove clientReqComplete from the test completely.
| s.pipe(req); | ||
| s.on('close', function(err) { | ||
| s.on('close', common.mustCall((err) => { | ||
| if (err) throw err; |
There was a problem hiding this comment.
You can replace this with assert.ifError(err);
|
Ping @JoshuaMays: Are you able to update this to accommodate the comments from @cjihrig? Do you need a little more explanation on one or both of the comments? |
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall
Trott
force-pushed
the
fix-test-pipe-file-to-http
branch
from
21625a7 to
2bfa353
Compare
|
Because this had been dormant for some time, I went ahead and addressed @cjihrig's nits and pushed directly to your branch, @JoshuaMays. Hope that's OK! @cjihrig Can you take a look and, if appropriate, update your review? Thanks! |
cjihrig
approved these changes
Dec 24, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 24, 2016
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: nodejs#10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 00da58d. |
targos
pushed a commit
that referenced
this pull request
Dec 26, 2016
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
Changing var defs to const/let, changing assert.equal to
assert.strictEqual. Wrapping functions called once with
common.mustCall