Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for building with shared OpenSSL lacking SSLv3. #101

Closed
wants to merge 1 commit into from

Conversation

bk2204
Copy link
Contributor

@bk2204 bk2204 commented Dec 6, 2014

Some distributions are disabling SSLv3 due to the POODLE attack. For example, the OpenSSL in Debian experimental has removed support for SSLv3_method and friends. If OpenSSL has SSLv3 disabled, throw an exception, just like when SSLv2 is disabled.

method = SSLv3_client_method();
#else
return env->ThrowError("SSLv3 methods disabled");
#endif
} else if (strcmp(*sslmethod, "SSLv23_method") == 0) {
method = SSLv23_method();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does SSLv23_method() still exist when OPENSSL_NO_SSL3 is defined?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does.

@bnoordhuis
Copy link
Member

@indutny Can you take a look? You've worked on this most recently.

@indutny
Copy link
Member

indutny commented Dec 6, 2014

I wonder if we could forward-port the similar commit from joyent/node: nodejs/node-v0.x-archive@d601c76

@indutny
Copy link
Member

indutny commented Dec 6, 2014

Actually, on a second thought, I don't want it to be done using --enable... stuff.

@indutny
Copy link
Member

indutny commented Dec 6, 2014

@bk2204 could you please take a look at https://github.com/iojs/io.js/blob/v0.12/CONTRIBUTING.md#commit and format your commit message according to it.

Some distributions disable SSLv3 due to POODLE.  In such a case, disable
the specific SSLv3 methods and throw an exception, much like the code
already does for SSLv2.  The SSLv23* code is retained because this is
OpenSSL's terminology for "no version in particular".
@bk2204
Copy link
Contributor Author

bk2204 commented Dec 7, 2014

Sure. Sorry about that.

@bk2204
Copy link
Contributor Author

bk2204 commented Dec 7, 2014

As I'm about to explain in my new commit message, SSLv23 is OpenSSL's terminology for "any version of SSL or TLS whatsoever". It's generally what you want to use, since you want it to negotiate the highest protocol supported by both sides. If SSLv3 is disabled, that will be any TLS version.

@indutny
Copy link
Member

indutny commented Dec 7, 2014

Looks good.

indutny pushed a commit that referenced this pull request Dec 10, 2014
Some distributions disable SSLv3 due to POODLE.  In such a case, disable
the specific SSLv3 methods and throw an exception, much like the code
already does for SSLv2.  The SSLv23* code is retained because this is
OpenSSL's terminology for "no version in particular".

Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #101
@indutny
Copy link
Member

indutny commented Dec 10, 2014

Landed in ac18ebd, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants