Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updated test-stream-pipe-unpipe-stream #10100

Closed

Conversation

rajapanidepu
Copy link

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 2, 2016
@@ -25,6 +25,9 @@ source.unpipe(dest2);
assert.strictEqual(source._readableState.pipes, dest1);
assert.notStrictEqual(source._readableState.pipes, dest2);

dest2.on('unpipe', assert.fail);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use common.fail instead of assert.fail.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it needs to include a message?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't, but others probably do. In that case, you'd have to do something like:

() => { common.fail('your message here'); }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR, not using message as it looks obvious in the code and most of the common.fail aren't using message.

test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cc @nodejs/streams

@mscdex mscdex added the stream Issues and PRs related to the stream subsystem. label Dec 3, 2016
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcollina
Copy link
Member

mcollina commented Dec 5, 2016

@mcollina
Copy link
Member

mcollina commented Dec 5, 2016

Merging now.

@mcollina
Copy link
Member

mcollina commented Dec 5, 2016

Merged as acb44d0

@mcollina mcollina closed this Dec 5, 2016
mcollina pushed a commit that referenced this pull request Dec 5, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: #10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Dec 5, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: #10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: nodejs#10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: nodejs#10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: #10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: #10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
test readableStream.unpipe(dest) is no operation when dest is
not a destination for readable stream.

PR-URL: #10100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This was referenced Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants