subsystem: test #10120
Closed
subsystem: test #10120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var => const, equal => strictEqual
cjihrig
approved these changes
Dec 5, 2016
Contributor
|
The commit message should be |
jasnell
approved these changes
Dec 5, 2016
Member
|
Yay! CI didn't totally blerf on this like it did last time. |
Trott
added
the
code-and-learn
Member
|
CI is ✅ Since this is (intentionally) a duplicate of a 5-day old PR that already got a bunch of 👍's, plus it's a pretty small and manageable change, I'm going to go ahead and land this. |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 6, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: nodejs#10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in 2df3fd9. |
Fishrock123
pushed a commit
that referenced
this pull request
Dec 6, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: #10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: nodejs#10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: nodejs#10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: #10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: #10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var => const * assert.equal() => assert.strictEqual() PR-URL: #10120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
var => const, equal => strictEqual
@Trott