Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: check result of uv_loop_init and uv_write #10126

Closed
wants to merge 1 commit into from
Closed

test: check result of uv_loop_init and uv_write #10126

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Dec 5, 2016 •
edited
Loading

@bnoordhuis
test: check result of uv_loop_init and uv_write
4e52e9c 
Silence coverity warnings about the return value not being checked.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 5, 2016
@mscdex mscdex added the inspector Issues and PRs related to the V8 inspector protocol label Dec 5, 2016
eugeneo
eugeneo approved these changes Dec 5, 2016
View reviewed changes
Copy link
Contributor

@eugeneo eugeneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@addaleax
Copy link
Member

addaleax commented Dec 7, 2016

Landed in a244147

@addaleax addaleax closed this Dec 7, 2016
addaleax pushed a commit that referenced this pull request Dec 7, 2016
@bnoordhuis @addaleax
test: check result of uv_loop_init and uv_write
a244147 
Silence coverity warnings about the return value not being checked.

PR-URL: #10126
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Dec 8, 2016
@bnoordhuis @addaleax
test: check result of uv_loop_init and uv_write
62f5a0b 
Silence coverity warnings about the return value not being checked.

PR-URL: #10126
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@bnoordhuis @addaleax
test: check result of uv_loop_init and uv_write
a696934 
Silence coverity warnings about the return value not being checked.

PR-URL: nodejs#10126
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@bnoordhuis @MylesBorins
test: check result of uv_loop_init and uv_write
bb75826 
Silence coverity warnings about the return value not being checked.

PR-URL: #10126
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo eugeneo approved these changes

Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@bnoordhuis @addaleax @eugeneo @jasnell @cjihrig @mscdex @MylesBorins @nodejs-github-bot