dtrace: resolve conversion warning (Windows) #10143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
This was referenced Dec 6, 2016
bnoordhuis
reviewed
Dec 6, 2016
| ->ToInteger(env->isolate())->Value(); | ||
| *valp = \ | ||
| static_cast<int32_t>(obj->Get(OneByteString(env->isolate(), #member)) \ | ||
| ->ToInteger(env->isolate())->Value()); |
brodycj
force-pushed
the
cb-dtrace-warning-fix
branch
2 times, most recently
from
75636a5
to
9087785
Compare
|
@bnoordhuis I did redo the fix according to your suggestion, thanks for the feedback! |
bnoordhuis
approved these changes
Dec 7, 2016
|
Yes the log could have been better. I wanted to put the "(Windows)" part on the subject line but then I couldn't fit a nice, complete commit subject into the standard 50 character length. My idea is to replace "(Windows)" with "(Windows build)". Short, sweet, and to the point. @bnoordhuis please reply if this is still not quite good enough. Otherwise I will do this tomorrow morning. |
|
Take a look at other commits for inspiration. It should consist of a short status line and a few more lines describing the what and why. I usually include the compiler message verbatim when it's a fix for a compiler warning. |
brodycj
force-pushed
the
cb-dtrace-warning-fix
branch
2 times, most recently
from
a6de333
to
d463558
Compare
|
I just amended the commit with the following message: |
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data
brodycj
force-pushed
the
cb-dtrace-warning-fix
branch
from
d463558
to
5a8126c
Compare
jasnell
approved these changes
Dec 16, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 27, 2016
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: #10143 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 099762d |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: #10143 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: #10143 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Should this be backported? |
|
ping |
3 tasks
ping @bnoordhuis I guess |
|
Could be back-ported. |
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: #10143 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Jun 20, 2017
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: #10143 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2017
Resolve build warnings on Windows with the following pattern: warning C4244: '=': conversion from 'int64_t' to 'int32_t', possible loss of data PR-URL: #10143 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX [macOS]; Linux i386 & amd64) andvcbuild test nosign(.\vcbuild.bat nosignthen.\vcbuild.bat test nosign nobuildas Administrator on Windows) PASS OKAdditional item
Affected core subsystem(s)
dtrace
Description of change
static_cast<int32_t> in SLURP_INT macro - resolve conversion warning on Windows
NOTE: This was originally a part of PR #10139 (build, warning, header, and include fixes).
ADDITIONAL NOTE: This and some warnings related to PR #10139 may indicate potential data loss scenarios. For future examination.