Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-handle-wrap-close-abort #10188

Closed
wants to merge 1 commit into from
Closed

test: refactor test-handle-wrap-close-abort #10188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions test/parallel/test-handle-wrap-close-abort.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,19 @@
'use strict';
require('../common');
const common = require('../common');

process.on('uncaughtException', function() { });
function noop() {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why you decided to define noop and uncaughtExceptionHandler, instead of just doing common.mustCall(function() {}, 2) inline.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No good reason. Aesthetics. Or indecisiveness. Or something. If you prefer it all inline, I'm happy to do that instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong preference. I was just curious.

const uncaughtExceptionHandler = common.mustCall(noop, 2);

process.on('uncaughtException', uncaughtExceptionHandler);

setTimeout(function() {
process.nextTick(function() {
var c = setInterval(function() {
const c = setInterval(function() {
clearInterval(c);
throw new Error('setInterval');
});
}, 1);
});
setTimeout(function() {
throw new Error('setTimeout');
});
}, 1);
});