Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor assert.equal, update syntax to ES6 #10190

Closed
wants to merge 1 commit into from
Closed

test: refactor assert.equal, update syntax to ES6 #10190

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 9, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test buffer

Description of change

alternative for #9914

@Trott Trott added buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. labels Dec 9, 2016
@Trott Trott mentioned this pull request Dec 9, 2016
Closed
3 tasks
@Trott
Copy link
Member Author

Trott commented Dec 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5338/

@Trott
Copy link
Member Author

Trott commented Dec 9, 2016

cc / fyi @prietoguy

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 12, 2016
@Trott
test: refactor assert.equal, update syntax to ES6
10891a1 
PR-URL: nodejs#10190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 12, 2016

Landed in 10891a1.

Thanks for the contribution, @prietoguy! 🎉

@Trott Trott closed this Dec 12, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
@Fishrock123
test: refactor assert.equal, update syntax to ES6
8b698d8 
PR-URL: #10190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@italoacasas italoacasas mentioned this pull request Dec 15, 2016
Merged
@Trott Trott deleted the nina-code-learn-2016 branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thefourtheye thefourtheye thefourtheye approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gibfahn gibfahn gibfahn approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @thefourtheye @cjihrig @gibfahn @MylesBorins