test: refactor the code in test-dns-ipv4 #10200
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't we also get rid of the |
cjihrig
reviewed
Dec 9, 2016
| @@ -39,119 +39,124 @@ function checkWrap(req) { | |||
| } | |||
|
|
|||
| TEST(function test_resolve4(done) { | |||
| var req = dns.resolve4('www.google.com', function(err, ips) { | |||
| const req = dns.resolve4('www.google.com', | |||
| common.mustCall(function(err, ips) { | |||
| if (err) throw err; | |||
There was a problem hiding this comment.
Would you mind replacing all of these lines in the file with assert.ifError(err);
There was a problem hiding this comment.
will perform these changes later tonight
edsadr
force-pushed
the
test-dns-ipv4
branch
from
b94e4c3 to
e5bc1ca
Compare
edsadr
changed the title
mscdex
reviewed
Dec 10, 2016
| var req = dns.resolve4('www.google.com', function(err, ips) { | ||
| if (err) throw err; | ||
| const req = dns.resolve4('www.google.com', | ||
| common.mustCall(function(err, ips) { |
There was a problem hiding this comment.
I'd rather either see this indented or use an arrow function to keep it on the previous line. If you go the arrow function route, we should be more consistent though and use it for the other callbacks too.
Same goes for the other instances below.
| const assert = require('assert'); | ||
| const common = require('../common'); |
There was a problem hiding this comment.
common should be required before anything else.
There was a problem hiding this comment.
will do this change too after get the #10219 approved, I am learning the right format for the code
3 tasks
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal
edsadr
force-pushed
the
test-dns-ipv4
branch
from
e5bc1ca to
286641c
Compare
|
changed the style to match the one agreed in #10219 |
|
any update on this one? |
italoacasas
approved these changes
Dec 23, 2016
|
|
thefourtheye
approved these changes
Dec 27, 2016
|
@italoacasas I think you meant @nodejs/collaborators |
italoacasas
pushed a commit
that referenced
this pull request
Dec 28, 2016
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Landed 4d3b487 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
use let and const instead of var
add missing common.mustCall for anonymous functions