test: refactor test-http-pause-resume-one-end #10210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setTimeout() with no duration -> setImmediate() * var -> const * remove unused variable `chunk`
Trott
added
http
nodejs-github-bot
added
dont-land-on-v7.x
test
cjihrig
approved these changes
Dec 10, 2016
santigimeno
approved these changes
Dec 10, 2016
santigimeno
approved these changes
Dec 13, 2016
targos
approved these changes
Dec 13, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 14, 2016
* setTimeout() with no duration -> setImmediate() * var -> const * remove unused variable `chunk` PR-URL: nodejs#10210 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
|
Landed in 6f02957 |
evanlucas
pushed a commit
that referenced
this pull request
Dec 14, 2016
* setTimeout() with no duration -> setImmediate() * var -> const * remove unused variable `chunk` PR-URL: #10210 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
* setTimeout() with no duration -> setImmediate() * var -> const * remove unused variable `chunk` PR-URL: #10210 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* setTimeout() with no duration -> setImmediate() * var -> const * remove unused variable `chunk` PR-URL: #10210 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* setTimeout() with no duration -> setImmediate() * var -> const * remove unused variable `chunk` PR-URL: #10210 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test http
Description of change
chunk