Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix broken link in COLLABORATOR_GUIDE.md #10267

Closed
wants to merge 1 commit into from
Closed

doc: fix broken link in COLLABORATOR_GUIDE.md #10267

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Dec 14, 2016 •
edited by gibfahn
Loading

  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

One of the links to CONTRIBUTING.md was broke in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Dec 14, 2016
@sam-github
Copy link
Contributor

LGTM

Trott
Trott reviewed Dec 14, 2016
View reviewed changes
COLLABORATOR_GUIDE.md
@@ -237,7 +237,8 @@ Save the file and close the editor. You'll be asked to enter a new
commit message for that commit. This is a good moment to fix incorrect
commit logs, ensure that they are properly formatted, and add
`Reviewed-By` lines.
* The commit message text must conform to the [commit message guidelines](../CONTRIBUTING.md#step-3-commit).
* The commit message text must conform to the
[commit message guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiniest of nits but might it be better to use one of the relative URLS ./CONTRIBUTING.md#step-3-commit or CONTRIBUTING.md#step-3-commit rather than the FQDN etc.? This way, if you're looking at the doc on a different branch, the link goes to the doc as it exists on that branch rather than to master. The problem with the current link is the .. at the start.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if you're going to do that, you could probably fix the one on L129 as well.

@gibfahn
Copy link
Member

gibfahn commented Dec 15, 2016

nit: s/broke/broken in the commit message

@mhdawson
doc: fix broken link in COLLABORATOR_GUIDE.md
d390135 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.
@mhdawson
Copy link
Member Author

Ok addressed comments so far.

@silverwind
Copy link
Contributor

silverwind commented Dec 15, 2016 •
edited
Loading

The link seems not broken to me, but I guess go ahead.

oops i missed the second line.

@mhdawson
Copy link
Member Author

Heading out on vacation so won't land until Jan, anybody else feel free to do so once the waiting time has passed.

@silverwind
Copy link
Contributor

Thanks! Landed in 9de2adc.

@silverwind silverwind closed this Dec 16, 2016
silverwind pushed a commit that referenced this pull request Dec 16, 2016
@mhdawson @silverwind
doc: fix broken link in COLLABORATOR_GUIDE.md
9de2adc 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

PR-URL: #10267
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
italoacasas pushed a commit that referenced this pull request Dec 17, 2016
@mhdawson @italoacasas
doc: fix broken link in COLLABORATOR_GUIDE.md
ee736b2 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

PR-URL: #10267
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@italoacasas italoacasas mentioned this pull request Dec 17, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
@mhdawson @cjihrig
doc: fix broken link in COLLABORATOR_GUIDE.md
4802b39 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

PR-URL: #10267
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2017
@mhdawson @MylesBorins
doc: fix broken link in COLLABORATOR_GUIDE.md
dbf799b 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

PR-URL: #10267
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@mhdawson @MylesBorins
doc: fix broken link in COLLABORATOR_GUIDE.md
980b4db 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

PR-URL: #10267
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@mhdawson @MylesBorins
doc: fix broken link in COLLABORATOR_GUIDE.md
843d455 
One of the links to CONTRIBUTING.md was broken in the doc.
Updated broken link to be the same as the other one in the
doc that was working.

PR-URL: #10267
Reviewed-By: Sam Roberts <sam@strongloop.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@mhdawson mhdawson deleted the fixcollab branch March 15, 2017 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@gibfahn gibfahn gibfahn approved these changes

@italoacasas italoacasas italoacasas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mhdawson @sam-github @gibfahn @silverwind @Trott @lpinca @cjihrig @italoacasas @MylesBorins @nodejs-github-bot