Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: return early if nextTickQueue is empty #10274

Merged
merged 1 commit into from
Dec 21, 2016
Merged

src: return early if nextTickQueue is empty #10274

merged 1 commit into from
Dec 21, 2016

Commits on Dec 21, 2016

  1. src: return early if nextTickQueue is empty 

    This brings the node::MakeCallback and node::AsyncWrap::MakeCallback
implementations into alignment in that they return early if the
nextTickQueue is empty after processing the MicrotaskQueue.

Include test to make sure early return happens. Test has text explaining
the conditions for the test to pass, since it relies on internal
mechanisms that aren't guaranteed in the future.

PR-URL: nodejs#10274
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @trevnorris
    trevnorris committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    8f8db14 View commit details
    Browse the repository at this point in the history