test: improve test-child-process-exec-buffer #10275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
italoacasas
added
the
child_process
edsadr
force-pushed
the
child-process-exec
branch
from
b51feea to
ac1a653
Compare
edsadr
changed the title
cjihrig
requested changes
Dec 16, 2016
| const assert = require('assert'); | ||
| const exec = require('child_process').exec; | ||
| const os = require('os'); | ||
| const str = 'hello'; | ||
|
|
||
| // default encoding | ||
| exec('echo ' + str, common.mustCall(function(err, stdout, stderr) { | ||
| assert.ok('string', typeof stdout, 'Expected stdout to be a string'); |
There was a problem hiding this comment.
These assert.ok() calls look wrong to me. Would you mean changing to assert.strictEqual() and also switching their order (actual then expected).
| @@ -18,5 +18,5 @@ exec('echo ' + str, { | |||
| }, common.mustCall(function(err, stdout, stderr) { | |||
| assert.ok(stdout instanceof Buffer, 'Expected stdout to be a Buffer'); | |||
There was a problem hiding this comment.
These assert.ok() calls look fine, but we could replace them for consistency.
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok
edsadr
force-pushed
the
child-process-exec
branch
from
ac1a653 to
fda691e
Compare
|
@cjihrig implemented your suggestions |
italoacasas
approved these changes
Dec 18, 2016
|
Landed f7f662c |
italoacasas
pushed a commit
that referenced
this pull request
Dec 18, 2016
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok PR-URL: #10275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok PR-URL: nodejs#10275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok PR-URL: #10275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok PR-URL: #10275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok PR-URL: #10275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* use const instead of var for required modules * use assert.strictEqual instead of assert.equal * use assert.strictEqual instead of assert.ok PR-URL: #10275 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change