-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assert: enforce type check in deepStrictEqual #10282
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,61 @@ | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const util = require('util'); | ||
|
||
// Template tag function turning an error message into a RegExp | ||
// for assert.throws() | ||
function re(literals, ...values) { | ||
let result = literals[0]; | ||
for (const [i, value] of values.entries()) { | ||
const str = util.inspect(value); | ||
// Need to escape special characters. | ||
result += str.replace(/[\\^$.*+?()[\]{}|=!<>:-]/g, '\\$&'); | ||
result += literals[i + 1]; | ||
} | ||
return new RegExp('^AssertionError: ' + result + '$'); | ||
} | ||
|
||
// Turn off no-restricted-properties because we are testing deepEqual! | ||
/* eslint-disable no-restricted-properties */ | ||
|
||
// See https://github.com/nodejs/node/issues/10258 | ||
{ | ||
const date = new Date('2016'); | ||
function FakeDate() {} | ||
FakeDate.prototype = Date.prototype; | ||
const fake = new FakeDate(); | ||
|
||
assert.doesNotThrow(() => assert.deepEqual(date, fake)); | ||
assert.doesNotThrow(() => assert.deepEqual(fake, date)); | ||
|
||
// For deepStrictEqual we check the runtime type, | ||
// then reveal the fakeness of the fake date | ||
assert.throws(() => assert.deepStrictEqual(date, fake), | ||
re`${date} deepStrictEqual Date {}`); | ||
assert.throws(() => assert.deepStrictEqual(fake, date), | ||
re`Date {} deepStrictEqual ${date}`); | ||
} | ||
|
||
{ // At the moment global has its own type tag | ||
const fakeGlobal = {}; | ||
Object.setPrototypeOf(fakeGlobal, Object.getPrototypeOf(global)); | ||
for (const prop of Object.keys(global)) { | ||
fakeGlobal[prop] = global[prop]; | ||
} | ||
assert.doesNotThrow(() => assert.deepEqual(fakeGlobal, global)); | ||
// Message will be truncated anyway, don't validate | ||
assert.throws(() => assert.deepStrictEqual(fakeGlobal, global)); | ||
} | ||
|
||
{ // At the moment process has its own type tag | ||
const fakeProcess = {}; | ||
Object.setPrototypeOf(fakeProcess, Object.getPrototypeOf(process)); | ||
for (const prop of Object.keys(process)) { | ||
fakeProcess[prop] = process[prop]; | ||
} | ||
assert.doesNotThrow(() => assert.deepEqual(fakeProcess, process)); | ||
// Message will be truncated anyway, don't validate | ||
assert.throws(() => assert.deepStrictEqual(fakeProcess, process)); | ||
} | ||
/* eslint-enable */ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can’t find the definition of
[Object.prototype.toString()]
… am I missing something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, forgot to put the reference link below :P