doc: fix broken link in COLLABORATOR_GUIDE.md #10337
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
suggested changes
Dec 19, 2016
| @@ -36,7 +36,7 @@ Collaborators or additional evidence that the issue has relevance, the | |||
| issue may be closed. Remember that issues can always be re-opened if | |||
| necessary. | |||
|
|
|||
| [**See "Who to CC in issues"**](./onboarding-extras.md#who-to-cc-in-issues) | |||
| [**See "Who to CC in issues"**](./docs/onboarding-extras.md#who-to-cc-in-issues) | |||
There was a problem hiding this comment.
Should be ./doc (it doesn't work if you click on it)
There was a problem hiding this comment.
Oops, yes. Thanks
gibfahn
approved these changes
Dec 19, 2016
There was a problem hiding this comment.
LGTM
(CI won't do anything here, but there's no downside as it's all green: https://ci.nodejs.org/job/node-test-commit/6726/)
cjihrig
approved these changes
Dec 19, 2016
Fishrock123
approved these changes
Dec 19, 2016
lpinca
approved these changes
Dec 19, 2016
italoacasas
approved these changes
Dec 19, 2016
|
Landed in 51d8fd3 |
julianduque
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #10337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
PR-URL: #10337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
PR-URL: #10337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
PR-URL: #10337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
PR-URL: #10337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
PR-URL: #10337 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
The link to the onboarding-extras.md document is broken and can not be called in COLLABORATOR_GUIDE.md as it is now located in the folder docs. I've changed the link that it points to the document.