Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc and test cert apis #10389

Merged
merged 6 commits into from
Jan 12, 2017
Merged

Doc and test cert apis #10389

merged 6 commits into from
Jan 12, 2017

Commits on Jan 12, 2017

  1. test: move common tls connect setup into fixtures 

    TLS connection setup boilerplate is common to many TLS tests, factor it
into a test fixture so tests are clearer to read and faster to write.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    99b0c2e View commit details
    Browse the repository at this point in the history

  2. test: check tls server verification with addCACert 

    SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

shigeki@acd5837

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Jan 12, 2017
    2 Configuration menu
    Copy the full SHA
    ea72331 View commit details
    Browse the repository at this point in the history

  3. doc: use correct tls certificate property name 

    Docs referred to an `issuer` property being optionally present, when it
should have referred to the `issuerCertificate` property.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    f966528 View commit details
    Browse the repository at this point in the history

  4. test: tls cert chain completion scenarios 

    PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    733c4a8 View commit details
    Browse the repository at this point in the history

  5. doc,test: tls .ca option supports multi-PEM files 

    PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    84a23c7 View commit details
    Browse the repository at this point in the history

  6. test: getgroups() may contain duplicate GIDs 

    Some systems may have multiple group names with the same group ID, in
which case getgroups() returns duplicate values, where `id -G` will
filter the duplicates. Unique and sort the arrays so they can be
compared.

PR-URL: nodejs#10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @sam-github
    sam-github committed Jan 12, 2017
    Configuration menu
    Copy the full SHA
    9271a41 View commit details
    Browse the repository at this point in the history