codeandlearn: use strictEqual instead of equal #10478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
jasnell
approved these changes
Dec 28, 2016
|
This looks good but the commit log message needs a bit of fixing up... EDIT by gibfahn: Cut commit message suggestion to <50 chars |
mscdex
reviewed
Dec 28, 2016
|
|
||
| var hello = new RegExp('/hello'); | ||
| assert.equal(true, hello.exec(server_response) != null); | ||
| assert.strictEqual(true, hello.exec(server_response) != null); |
There was a problem hiding this comment.
Maybe we can change this assertion and the one below to instead be like:
assert.notEqual(null, hello.exec(server_response));
There was a problem hiding this comment.
I agree. Making the changes now.
cjihrig
requested changes
Dec 28, 2016
|
|
||
| var hello = new RegExp('/hello'); | ||
| assert.equal(true, hello.exec(server_response) != null); | ||
| assert.notEqual(null, hello.exec(server_response)); |
There was a problem hiding this comment.
Can you use notStrictEqual() here.
There was a problem hiding this comment.
Ah yes, I missed that it was a regexp so it will always return null on failure. notStrictEqual() is better here and below.
|
|
||
| var quit = new RegExp('/quit'); | ||
| assert.equal(true, quit.exec(server_response) != null); | ||
| assert.notEqual(null, quit.exec(server_response)); |
italoacasas
approved these changes
Dec 29, 2016
|
@cjihrig .. does this LGTY? |
cjihrig
approved these changes
Dec 29, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 29, 2016
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 3d290d2 |
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
PR-URL: #10478 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 24, 2023
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Description of change