Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: always initialize tracing controller in agent #10507

Closed
wants to merge 1 commit into from
Closed

src: always initialize tracing controller in agent #10507

wants to merge 1 commit into from

Conversation

matthewloring
Copy link

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

@nodejs-github-bot nodejs-github-bot added dont-land-on-v7.x c++ Issues and PRs that require attention from people who are familiar with C++. labels Dec 28, 2016
@matthewloring matthewloring changed the title src: initialize controller in agent constructor src: always initialize tracing controller in agent Dec 28, 2016
@matthewloring
Copy link
Author

CI: https://ci.nodejs.org/job/node-test-pull-request/5618/

@matthewloring
Copy link
Author

CI failures all look unrelated

@matthewloring
Copy link
Author

Landed in: 81d0717

@jasnell
Copy link
Member

jasnell commented Dec 29, 2016

It's fine that this landed but typically we need to wait 48 hours before landing any pr that is not considered trivial... Which is usually limited to doc only or meta prs.

@matthewloring
Copy link
Author

Apologies, I will hold off in the future.

This was referenced Jan 19, 2017
Closed
Closed
@mscdex mscdex added the trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events. label Jan 29, 2017
@evanlucas
Copy link
Contributor

Marking don't land since it depends on #9304

targos pushed a commit to targos/node that referenced this pull request Mar 1, 2017
@targos
src: always initialize tracing controller in agent
7fdeeb1 
PR-URL: nodejs#10507
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 1, 2017
@italoacasas
src: always initialize tracing controller in agent
b89b2a7 
PR-URL: nodejs#10507
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Mar 1, 2017
Merged
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

Marking as don't land on 4 and 6 because #9304 is marked don't land

@matthewloring matthewloring deleted the trace-agent branch August 22, 2017 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. trace_events Issues and PRs related to V8, Node.js core, and userspace code trace events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@matthewloring @jasnell @evanlucas @cjihrig @mscdex @targos @nodejs-github-bot