Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-stream-unshift-read-race #10532

Closed
wants to merge 1 commit into from
Closed

test: refactor test-stream-unshift-read-race #10532

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 30, 2016

  • add RegExp as second argument to assert.throws()
  • replace process.on('exit', ...) boolean checks with common.mustCall()
  • assert.equal() -> assert.strictEqual()
  • add 1 ms duration as second argument to setTimeout()
  • var -> const
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test stream

@Trott
test: refactor test-stream-unshift-read-race
64cdbaf 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const
@Trott Trott added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels Dec 30, 2016
@Trott
Copy link
Member Author

Trott commented Dec 30, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/5632/

lpinca
lpinca reviewed Dec 30, 2016
View reviewed changes
test/parallel/test-stream-unshift-read-race.js
assert.equal(written.length, 18);
assert(ended, 'stream ended');
assert(finished, 'stream finished');
assert.strictEqual(written.length, 18);
console.log('ok');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: does it make sense to remove this?

Trott added a commit to Trott/io.js that referenced this pull request Jan 2, 2017
@Trott
test: refactor test-stream-unshift-read-race
55f5301 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const

PR-URL: nodejs#10532
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 2, 2017

Landed in 55f5301

@Trott Trott closed this Jan 2, 2017
@evanlucas evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
@Trott @evanlucas
test: refactor test-stream-unshift-read-race
4f0fd6a 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const

PR-URL: #10532
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
@Trott @evanlucas
test: refactor test-stream-unshift-read-race
82575f9 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const

PR-URL: #10532
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
@Trott @MylesBorins
test: refactor test-stream-unshift-read-race
2c1d0ad 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const

PR-URL: #10532
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
@Trott @MylesBorins
test: refactor test-stream-unshift-read-race
14b8297 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const

PR-URL: #10532
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
@Trott @MylesBorins
test: refactor test-stream-unshift-read-race
9cee678 
* add RegExp as second argument to assert.throws()
* replace process.on('exit', ...) boolean checks with common.mustCall()
* assert.equal() -> assert.strictEqual()
* add 1 ms duration as second argument to setTimeout()
* var -> const

PR-URL: #10532
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the stream-unshift-read-race branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @lpinca @MylesBorins @nodejs-github-bot