test: improve the code in test-fs-read-stream #10556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
mscdex
reviewed
Dec 31, 2016
| const fd = fs.openSync(file, 'r'); | ||
| const stream = fs.createReadStream(null, { fd: fd, encoding: 'utf8' }); | ||
|
|
||
| stream.on('data', common.mustCall((data) => { |
There was a problem hiding this comment.
I think the common.mustCall() should be removed since there could be more than one 'data' event and we're already verifying the output on process exit anyway.
Trott
reviewed
Jan 1, 2017
|
|
||
| process.on('exit', function() { | ||
| process.on('exit', () => { | ||
| fs.unlinkSync(file); |
There was a problem hiding this comment.
While we're in here editing the file, can you please remove fs.unlinkSync(file);? (There's no need for tests to clean up the temp dir on exit as all tests that use the temp dir should refresh it before using it.)
|
LGTM |
italoacasas
approved these changes
Jan 2, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions
|
solved the conflicts after ff1efa6 , please set the CI again |
|
Landed 7a46b99 |
italoacasas
pushed a commit
that referenced
this pull request
Jan 3, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10556 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10556 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10556 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Brian White <mscdex@mscdex.net>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: #10556 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10556 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Brian White <mscdex@mscdex.net>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
* use const and let instead of var * use assert.strictEqual instead of assert.equal * use arrow functions PR-URL: nodejs#10556 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test