Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: improve removeListener() performance #10572

Merged
merged 1 commit into from
Jan 5, 2017

Commits on Jan 5, 2017

  1. events: improve removeListener() performance

    array.shift() seems to be faster than arrayClone() when the item
    to remove is at the front (at least with V8 5.4).
    
    PR-URL: nodejs#10572
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    mscdex committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    aab1dd6 View commit details
    Browse the repository at this point in the history