Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: minor cleanup in test-fs-*-buffer tests #10611

Closed
wants to merge 2 commits into from
Closed

test: minor cleanup in test-fs-*-buffer tests #10611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9f9aa1
test: check error in test-fs-read-buffer
addaleax Jan 4, 2017
e101f83
test: cleanup test-fs-write-buffer
addaleax Jan 4, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/parallel/test-fs-read-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ function test(bufferAsync, bufferSync, expected) {
expected.length,
0,
common.mustCall((err, bytesRead) => {
assert.ifError(err);
assert.strictEqual(bytesRead, expected.length);
assert.deepStrictEqual(bufferAsync, Buffer.from(expected));
}));
Expand Down
24 changes: 12 additions & 12 deletions test/parallel/test-fs-write-buffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@ common.refreshTmpDir();
// fs.write with all parameters provided:
{
const filename = path.join(common.tmpDir, 'write1.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err);

const cb = common.mustCall(function(err, written) {
const cb = common.mustCall((err, written) => {
assert.ifError(err);

assert.strictEqual(expected.length, written);
fs.closeSync(fd);

var found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual(expected.toString(), found);
assert.strictEqual(expected.toString(), found);
});

fs.write(fd, expected, 0, expected.length, null, cb);
Expand All @@ -30,17 +30,17 @@ common.refreshTmpDir();
// fs.write with a buffer, without the length parameter:
{
const filename = path.join(common.tmpDir, 'write2.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err);

const cb = common.mustCall(function(err, written) {
const cb = common.mustCall((err, written) => {
assert.ifError(err);

assert.strictEqual(2, written);
fs.closeSync(fd);

const found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual('lo', found);
assert.strictEqual('lo', found);
});

fs.write(fd, Buffer.from('hello'), 3, cb);
Expand Down Expand Up @@ -90,17 +90,17 @@ common.refreshTmpDir();
// fs.write with offset and length passed as undefined followed by the callback:
{
const filename = path.join(common.tmpDir, 'write5.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err);

const cb = common.mustCall(function(err, written) {
const cb = common.mustCall((err, written) => {
assert.ifError(err);

assert.strictEqual(expected.length, written);
fs.closeSync(fd);

const found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual(expected.toString(), found);
assert.strictEqual(expected.toString(), found);
});

fs.write(fd, expected, undefined, undefined, cb);
Expand All @@ -110,17 +110,17 @@ common.refreshTmpDir();
// fs.write with a Uint8Array, without the offset and length parameters:
{
const filename = path.join(common.tmpDir, 'write6.txt');
fs.open(filename, 'w', 0o644, common.mustCall(function(err, fd) {
fs.open(filename, 'w', 0o644, common.mustCall((err, fd) => {
assert.ifError(err);

const cb = common.mustCall(function(err, written) {
const cb = common.mustCall((err, written) => {
assert.ifError(err);

assert.strictEqual(expected.length, written);
fs.closeSync(fd);

const found = fs.readFileSync(filename, 'utf8');
assert.deepStrictEqual(expected.toString(), found);
assert.strictEqual(expected.toString(), found);
});

fs.write(fd, Uint8Array.from(expected), cb);
Expand Down