Skip to content

test: Revert add option to use node in path #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: Revert add option to use node in path #10613

wants to merge 1 commit into from

Conversation

@thefourtheye
Copy link
Contributor

@thefourtheye thefourtheye commented Jan 4, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools

Description

This reverts commit 4198253, landed in
#9674.

This fails at

File "tools/test.py", line 1429, in ProcessOptions
options.j = int(cores) if cores is not None else
multiprocessing.cpu_count()

with the error

NotImplementedError: cannot determine number of cpus

from

File "...multiprocessing/init.py", line 136, in cpu_count
raise NotImplementedError('cannot determine number of cpus')

on MacOS machines.

@nodejs-github-bot nodejs-github-bot added tools Issues and PRs related to the tools directory. dont-land-on-v7.x labels Jan 4, 2017
evanlucas
evanlucas suggested changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, revert commits are like Revert "<commit message>". I think changelog-maker even expects them to be that way.

@thefourtheye
Copy link
Contributor Author

thefourtheye commented Jan 4, 2017

@evanlucas But that exceeds the 50 chars limit. Is that okay?

Fishrock123
Fishrock123 approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @evanlucas's comemnt, this should be made via git revert unless there is some other issue.

Please merge some form of this ASAP.

@Fishrock123
Copy link
Contributor

Fishrock123 commented Jan 4, 2017

@thefourtheye I think so for reverts. I would wager it's happened before.

@evanlucas
Copy link
Contributor

evanlucas commented Jan 4, 2017

@thefourtheye yes. It should just be with git revert <sha>.

@thefourtheye
Copy link
Contributor Author

thefourtheye commented Jan 4, 2017

@evanlucas @Fishrock123 Thanks 👍 Updated the commit.

@jasnell
Copy link
Member

jasnell commented Jan 4, 2017

Oy good catch. Missed that entirely on my initial review. LGTM

@mscdex mscdex added the test Issues and PRs related to the tests. label Jan 4, 2017
gibfahn
gibfahn approved these changes Jan 4, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks identical to git revert. +1 to landing straightaway.

evanlucas
evanlucas approved these changes Jan 4, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, +1 to landing sooner than the 48 minimum

@thefourtheye
Copy link
Contributor Author

thefourtheye commented Jan 4, 2017

Landed in 26bf954

@thefourtheye thefourtheye deleted the revert-tools-test branch January 4, 2017 17:49
thefourtheye added a commit that referenced this pull request Jan 4, 2017
@thefourtheye
Revert "test: test.py add option to use node in path"
26bf954 
This reverts commit 4198253.

PR-URL: #10613

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jbergstroem
jbergstroem reviewed Jan 4, 2017
View reviewed changes
Copy link
Member

@jbergstroem jbergstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge approval. Can confirm.

italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@thefourtheye
Revert "test: test.py add option to use node in path"
8e5f399 
This reverts commit 4198253.

PR-URL: nodejs#10613

Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jan 19, 2017
Closed
Closed
@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@jbergstroem jbergstroem jbergstroem left review comments

@evanlucas evanlucas evanlucas approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@gibfahn gibfahn gibfahn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@thefourtheye @Fishrock123 @evanlucas @jasnell @jbergstroem @gibfahn @mscdex @targos @nodejs-github-bot