Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention cc-ing nodejs/url team for reviews #10652

Closed
wants to merge 1 commit into from
Closed

doc: mention cc-ing nodejs/url team for reviews #10652

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Jan 6, 2017

Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

fyi @nodejs/url

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. lts-watch-v6.x labels Jan 6, 2017
@addaleax addaleax added meta Issues and PRs related to the general management of the project. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Jan 6, 2017
TimothyGu
TimothyGu reviewed Jan 6, 2017
View reviewed changes
doc/onboarding-extras.md
@@ -13,6 +13,7 @@
| `lib/{crypto,tls,https}` | @nodejs/crypto |
| `lib/domains` | @misterdjules |
| `lib/fs`, `src/{fs|file}` | @nodejs/fs |
| `lib/internal/url.js` | @nodejs/url |
Copy link
Member

@TimothyGu TimothyGu Jan 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: None Pretty much none of the other entries in the file seem to have .js

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TimothyGu thanks for noticing, fixed!

Trott
Trott reviewed Jan 6, 2017
View reviewed changes
doc/onboarding-extras.md
@@ -13,6 +13,7 @@
| `lib/{crypto,tls,https}` | @nodejs/crypto |
| `lib/domains` | @misterdjules |
| `lib/fs`, `src/{fs|file}` | @nodejs/fs |
| `lib/internal/url` | @nodejs/url |
Copy link
Member

@Trott Trott Jan 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be lib/url? internal seems to be implied everywhere else (e.g., lib/fs would presumably include lib/internal/fs.js).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's about difference in implementations. WHATWG vs original url.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep... lib/internal/url.js is the home of the new implementation. Intentionally put there to keep it distinct from the older lib/url.js

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's going to be confusing/unclear if there's not a separate entry for lib/url in addition to the entry for lib/internal/url. Not opposed to this landing as is, but if there's different people to cc depending on which one you're working on, I'd prefer that there be entries for both.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a note column and mention that lib/url doesn't apply to this would help?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think there is anybody in particular to ping for lib/url, and I think leaving this as-is is going to be fine. If it turns out to be a horrible idea, we can add a note or find people to @mention for lib/url.

joyeecheung
joyeecheung requested changes Jan 6, 2017
View reviewed changes
doc/onboarding-extras.md
@@ -13,6 +13,7 @@
| `lib/{crypto,tls,https}` | @nodejs/crypto |
| `lib/domains` | @misterdjules |
| `lib/fs`, `src/{fs|file}` | @nodejs/fs |
Copy link
Member

@joyeecheung joyeecheung Jan 6, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is src/node_url.cc too.

EDIT: should be src/node_url, there is also a .h.

@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

ping @addaleax

@addaleax
doc: mention cc-ing nodejs/url team for reviews
09590d0 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.
@addaleax
Copy link
Member Author

Sorry, missed @joyeecheung’s review. updated!

@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

@joyeecheung ... does this look good to you now?

jasnell pushed a commit that referenced this pull request Jan 11, 2017
@addaleax @jasnell
doc: mention cc-ing nodejs/url team for reviews
fa38361 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: #10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 11, 2017

Landed in fa38361

@jasnell jasnell closed this Jan 11, 2017
@addaleax addaleax deleted the doc-cc-nodejs-url branch January 12, 2017 18:01
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@addaleax @italoacasas
doc: mention cc-ing nodejs/url team for reviews
3e29272 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: nodejs#10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@addaleax @italoacasas
doc: mention cc-ing nodejs/url team for reviews
23f85ab 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: nodejs#10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
@addaleax @italoacasas
doc: mention cc-ing nodejs/url team for reviews
63df2b6 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: nodejs#10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@addaleax @italoacasas
doc: mention cc-ing nodejs/url team for reviews
56ea7eb 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: nodejs#10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
@addaleax @MylesBorins
doc: mention cc-ing nodejs/url team for reviews
005f2b3 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: #10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@addaleax @MylesBorins
doc: mention cc-ing nodejs/url team for reviews
8e807f6 
Add the nodejs/url github team to the table of people to /cc for
reviews on the WHATWG URL code.

PR-URL: #10652
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@Trott Trott Trott left review comments

@mscdex mscdex mscdex left review comments

@gibfahn gibfahn gibfahn approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @jasnell @mscdex @Trott @Fishrock123 @TimothyGu @joyeecheung @gibfahn @MylesBorins @nodejs-github-bot