-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update BUILDING.md #10669
doc: update BUILDING.md #10669
Conversation
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code.
@nodejs/platform-windows @nodejs/documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (based on https://blogs.msdn.microsoft.com/vcblog/2015/07/24/setup-changes-in-visual-studio-2015-affecting-c-developers/), it'd be good to have someone from @nodejs/platform-windows weigh in as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: #10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Landed in c9b52aa |
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: nodejs#10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: #10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Added a note about Visual Studio 2015 feature which should be installed for building Node.js source code. PR-URL: #10669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Added a note about Visual Studio 2015 feature which should
be installed for building Node.js source code.