Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-watch-file.js #10679

Closed
wants to merge 2 commits into from
Closed

test: refactor test-watch-file.js #10679

wants to merge 2 commits into from

Conversation

sivaprs
Copy link
Contributor

@sivaprs sivaprs commented Jan 7, 2017

  • use const and let instead of var
  • use arrow function
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

description

  • use const and let instead of var
  • use arrow function

@sivaprs
test: refactor test-watch-file.js
f49e63e 
* use const and let instead of var
* use arrow function
@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 7, 2017
@mscdex mscdex added fs Issues and PRs related to the fs subsystem / file system. and removed dont-land-on-v7.x labels Jan 7, 2017
@sivaprs
Copy link
Contributor Author

sivaprs commented Jan 8, 2017

cc @thefourtheye

thefourtheye
thefourtheye reviewed Jan 9, 2017
View reviewed changes
test/pummel/test-watch-file.js
@@ -5,13 +5,13 @@ const assert = require('assert');
const fs = require('fs');
const path = require('path');

var f = path.join(common.fixturesDir, 'x.txt');
const f = path.join(common.fixturesDir, 'x.txt');

console.log('watching for changes of ' + f);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove console.logs in this file?

@italoacasas
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/5766/console

jasnell pushed a commit that referenced this pull request Jan 10, 2017
@sivaprs @jasnell
test: refactor test-watch-file.js
a799854 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 10, 2017

Landed in a799854

@jasnell jasnell closed this Jan 10, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@sivaprs @italoacasas
test: refactor test-watch-file.js
b1bf481 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@sivaprs @italoacasas
test: refactor test-watch-file.js
d930716 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@sivaprs @italoacasas
test: refactor test-watch-file.js
d469965 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@sivaprs @italoacasas
test: refactor test-watch-file.js
17d9a73 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: nodejs#10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor test-watch-file.js
743bdf9 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sivaprs @MylesBorins
test: refactor test-watch-file.js
803040c 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor test-watch-file.js
9acc86f 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sivaprs @MylesBorins
test: refactor test-watch-file.js
ab65429 
* use const and let instead of var
* use arrow function
* removed console.log statements

PR-URL: #10679
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@italoacasas italoacasas italoacasas approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@sivaprs @italoacasas @jasnell @thefourtheye @lpinca @cjihrig @mscdex @MylesBorins @nodejs-github-bot