Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test, eslintrc: s/assert.equal/assert.strictEqual/ #10698

Merged
merged 2 commits into from
Jan 11, 2017
Merged

test, eslintrc: s/assert.equal/assert.strictEqual/ #10698

merged 2 commits into from
Jan 11, 2017
+1,723 −1,681

Commits on Jan 11, 2017

  1. test: s/assert.equal/assert.strictEqual/ 

    Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: nodejs#10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    @gibfahn
    gibfahn committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    3d2aef3 View commit details
    Browse the repository at this point in the history

  2. assert, tools: enforce strict (not)equal in eslint 

    Extend no-restricted-properties to catch use of assert.equal() and
assert.notEqual() and require assert.strictEqual() or
assert.notStrictEqual() instead.

Also update the eslint-ignore in lib/assert.js to avoid
assert.equal/notEqual linter errors in their definitions.

PR-URL: nodejs#10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
    @gibfahn
    gibfahn committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    6509d74 View commit details
    Browse the repository at this point in the history