doc: fix misleading language in vm docs #10708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
mscdex
reviewed
Jan 9, 2017
| altering objects from the calling thread's context in unwanted ways. | ||
| *Note*: The `require()` in the above case shares the state with the context it | ||
| is passed from. This may introduce risks when untrusted code is executed, e.g. | ||
| altering objects from the context in unwanted ways. |
There was a problem hiding this comment.
I didn't change this sentence (except the addition of an article), but I think the author meant that require had been passed from the other context. However, it would be nice to reword the whole sentence, since there are some other quirks; e.g., why "shares the state with the context" if it just shares the same context.
There was a problem hiding this comment.
@mscdex ah, sorry, we are talking about different lines.
There was a problem hiding this comment.
Yes, "in" should be used here.
|
@mscdex I've pushed a new commit. What about the line I've confused one you were talking about with, I think it's pretty okay though not perfect and I don't see a better way to reword it now. |
|
LGTM. @aqrln The rest is fine I think for now. |
jasnell
approved these changes
Jan 9, 2017
The note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads. Fixes: nodejs#10697
|
Landed in 8781e61. Thanks! |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
The note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads. Fixes: nodejs#10697 PR-URL: nodejs#10708 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
The note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads. Fixes: nodejs#10697 PR-URL: nodejs#10708 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
The note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads. Fixes: nodejs#10697 PR-URL: nodejs#10708 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
The note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads. Fixes: nodejs#10697 PR-URL: nodejs#10708 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @mscdex noted, the note following the http.Server example in the vm documentation contains misleading language. This commit removes the incorrect reference to threads.
Fixes: #10697
Checklist
Affected core subsystem(s)
doc