doc: note v5, v0.10, v0.12 EOL in the CHANGELOG #10743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It had some minor errors in td/th html tags.
Make it clear that v5, v0.10, and v0.12 are EOL and unsupported. We probably don't want people seeing 'LTS' badge next to those in the current Node.js repo and think that those are still supported. Not everyone is aware of the nodejs/LTS repo. This also includes the dates for v5, v0.10 and v0.12 EOL: - 2016-07-01 for v5 - 2016-11-01 for v0.10 - 2017-01-01 for v0.12
nodejs-github-bot
added
meta
|
The same page also says:
Should 5.11.1, 0.12.18 and 0.10.48 still be in bold? |
Make v5, v0.10, v0.12 not bold in the CHANGELOG.md, as bold is said to be an indication of the most recent actively supported release futher on the same page.
ChALkeR
force-pushed
the
changelog-fixes
branch
from
5bf4322
to
8812456
Compare
|
@richardlau Good point, thanks! Fixed.
|
jasnell
approved these changes
Jan 11, 2017
jasnell
pushed a commit
that referenced
this pull request
Jan 16, 2017
* It had some minor errors in td/th html tags. * Make it clear that v5, v0.10, and v0.12 are EOL and unsupported. We probably don't want people seeing 'LTS' badge next to those in the current Node.js repo and think that those are still supported. Not everyone is aware of the nodejs/LTS repo. This also includes the dates for v5, v0.10 and v0.12 EOL: - 2016-07-01 for v5 - 2016-11-01 for v0.10 - 2017-01-01 for v0.12 * Make v5/v0.10/v0.12 not bold in CHANGELOG Make v5, v0.10, v0.12 not bold in the CHANGELOG.md, as bold is said to be an indication of the most recent actively supported release futher on the same page. PR-URL: #10743 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Squashed and landed in f3f2468 |
|
@jasnell Thanks! I somehow totally forgot about this… :-( |
This was referenced Jan 19, 2017
|
This isn't landing cleanly on v7.x-staging. Mind backporting? |
3 tasks
|
@ChALkeR should this be backported to 6.x? |
|
@gibfahn Yes, it looks like this should be backported, without the v7 line, though. https://raw.githubusercontent.com/nodejs/node/v6.x/CHANGELOG.md has the same formatting errors ( I am not able to backport this at the moment, unfortunately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CHANGELOG page looks like this now:
Seeing that, one might think that 0.12 and 0.10 are currently in the LTS.
So this commit makes it clear that v5, v0.10, and v0.12 are EOL and unsupported:
We probably don't want people seeing
LTSbadge next to those in the current Node.js repo and think that those are still supported. Not everyone is aware of the nodejs/LTS repo.This also includes the dates for v5, v0.10 and v0.12 EOL:
Checklist
Affected core subsystem(s)
doc