Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check error msg in test/parallel/test-writeint.js #10755

Closed
wants to merge 1 commit into from
Closed

test: check error msg in test/parallel/test-writeint.js #10755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions test/parallel/test-writeint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
*/
require('../common');
const assert = require('assert');
const errorOutOfBounds = /^TypeError: "value" argument is out of bounds$/;

function test8(clazz) {
const buffer = new clazz(2);
Expand All @@ -17,10 +18,10 @@ function test8(clazz) {
/* Make sure we handle truncation correctly */
assert.throws(function() {
buffer.writeInt8(0xabc, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt8(0xabc, 0);
});
}, errorOutOfBounds);

/* Make sure we handle min/max correctly */
buffer.writeInt8(0x7f, 0);
Expand All @@ -30,10 +31,10 @@ function test8(clazz) {
assert.strictEqual(0x80, buffer[1]);
assert.throws(function() {
buffer.writeInt8(0x7f + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt8(-0x80 - 1, 0);
});
}, errorOutOfBounds);
}


Expand Down Expand Up @@ -70,10 +71,10 @@ function test16(clazz) {
assert.strictEqual(0x00, buffer[3]);
assert.throws(function() {
buffer.writeInt16BE(0x7fff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt16BE(-0x8000 - 1, 0);
});
}, errorOutOfBounds);

buffer.writeInt16LE(0x7fff, 0);
buffer.writeInt16LE(-0x8000, 2);
Expand All @@ -83,10 +84,10 @@ function test16(clazz) {
assert.strictEqual(0x80, buffer[3]);
assert.throws(function() {
buffer.writeInt16LE(0x7fff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt16LE(-0x8000 - 1, 0);
});
}, errorOutOfBounds);
}


Expand Down Expand Up @@ -139,10 +140,10 @@ function test32(clazz) {
assert.strictEqual(0x00, buffer[7]);
assert.throws(function() {
buffer.writeInt32BE(0x7fffffff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt32BE(-0x80000000 - 1, 0);
});
}, errorOutOfBounds);

buffer.writeInt32LE(0x7fffffff, 0);
buffer.writeInt32LE(-0x80000000, 4);
Expand All @@ -156,10 +157,10 @@ function test32(clazz) {
assert.strictEqual(0x80, buffer[7]);
assert.throws(function() {
buffer.writeInt32LE(0x7fffffff + 1, 0);
});
}, errorOutOfBounds);
assert.throws(function() {
buffer.writeInt32LE(-0x80000000 - 1, 0);
});
}, errorOutOfBounds);
}


Expand Down