Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test cases to test-readline-keys.js #10772

Closed

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 12, 2017

Add test cases for all patterns of readline.js.
Make use of arrow function.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. dont-land-on-v7.x labels Jan 12, 2017
@mscdex mscdex added readline Issues and PRs related to the built-in readline module. and removed dont-land-on-v7.x labels Jan 12, 2017
@Trott
Copy link
Member

Trott commented Jan 12, 2017

@hiroppy
Copy link
Member Author

hiroppy commented Jan 16, 2017

@Trott Would you be able to confirm this PR?

@Trott
Copy link
Member

Trott commented Jan 17, 2017

@nodejs/testing Anyone want to take a look at this one? This looks to me like it changes existing test cases (but not behavior) rather than merely adding new test cases. Are we OK with that?

@joyeecheung
Copy link
Member

Looks like this just appends new keys to the same test case instead of putting them in a following one. I think it's probably safe.

@hiroppy hiroppy force-pushed the feature/add-readline-keys-test branch from b3fcc5e to a5d702a Compare February 3, 2017 05:11
@hiroppy
Copy link
Member Author

hiroppy commented Feb 3, 2017

jasnell pushed a commit that referenced this pull request Feb 8, 2017
PR-URL: #10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell
Copy link
Member

jasnell commented Feb 8, 2017

Landed in 2db3b94

@jasnell jasnell closed this Feb 8, 2017
@hiroppy hiroppy deleted the feature/add-readline-keys-test branch February 9, 2017 02:55
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 9, 2017
PR-URL: nodejs#10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
PR-URL: nodejs#10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
PR-URL: nodejs#10772
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 7, 2017

would need backport PRs to land in v6 or v4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
readline Issues and PRs related to the built-in readline module. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants