-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test cases to test-readline-keys.js #10772
Conversation
@Trott Would you be able to confirm this PR? |
@nodejs/testing Anyone want to take a look at this one? This looks to me like it changes existing test cases (but not behavior) rather than merely adding new test cases. Are we OK with that? |
Looks like this just appends new keys to the same test case instead of putting them in a following one. I think it's probably safe. |
b3fcc5e
to
a5d702a
Compare
PR-URL: #10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Landed in 2db3b94 |
PR-URL: nodejs#10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: nodejs#10772 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
would need backport PRs to land in v6 or v4 |
Add test cases for all patterns of readline.js.
Make use of arrow function.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test