Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP response getHeader doc fix #10817

Closed
wants to merge 1 commit into from
Closed

Conversation

fhalde
Copy link
Contributor

@fhalde fhalde commented Jan 15, 2017

According to #10803
getHeader need not be called only before it is flushed implicitly.

  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. lts-watch-v6.x labels Jan 15, 2017
Reads out a header that's already been queued but not sent to the client. Note
that the name is case insensitive. This can only be called before headers get
implicitly flushed.
Reads out a header that's already been queued but not sent to the client. Note that the name is case insensitive
Copy link
Member

@gibfahn gibfahn Jan 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you keep the first two sentences wrapped to <80chars? The diff should look something like:

-that the name is case insensitive.  This can only be called before headers get
-implicitly flushed.
+that the name is case insensitive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, what @gibfahn said.

@gibfahn
Copy link
Member

gibfahn commented Jan 15, 2017

cc/ @mscdex

Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the @gibfahn's suggestion.

Copy link
Contributor

@thefourtheye thefourtheye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, the commit log should have subsystem. Please refer https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.
@mscdex
Copy link
Contributor

mscdex commented Jan 17, 2017

LGTM

jasnell pushed a commit that referenced this pull request Jan 18, 2017
According to #10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: #10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 18, 2017

Landed in 90a2bb5

@jasnell jasnell closed this Jan 18, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
According to nodejs#10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: nodejs#10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
According to #10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: #10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
According to #10803
getHeader need not be called only before it is flushed implicitly.

PR-URL: #10817
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants