Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove unnecessary parameter for assertCrypto() #10834

Closed
wants to merge 1 commit into from
Closed

lib: remove unnecessary parameter for assertCrypto() #10834

wants to merge 1 commit into from

Conversation

JacksonTian
Copy link
Contributor

@JacksonTian JacksonTian commented Jan 16, 2017 •
edited
Loading

The exports parameter is unnecessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

_tls_legacy, _tls_wrap, crypto, https, internal/util, tls

@JacksonTian
lib: remove unnecessary parameter for assertCrypto()
019faee 
The `exports` parameter is unnecessary.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. lts-watch-v6.x labels Jan 16, 2017
@mscdex
Copy link
Contributor

mscdex commented Jan 16, 2017

LGTM.

@mscdex mscdex added the crypto Issues and PRs related to the crypto subsystem. label Jan 16, 2017
@sam-github
Copy link
Contributor

Looks unnecessary to me, but @jasnell added it, maybe he can comment?

jasnell
jasnell approved these changes Jan 16, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This was a remnant from an earlier iteration of the change that was made here that did not get completely cleaned up.

@JacksonTian
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/5882/

@JacksonTian
Copy link
Contributor Author

Landed in 69674f4 .

@JacksonTian JacksonTian deleted the assert_crypto branch January 18, 2017 03:19
JacksonTian added a commit that referenced this pull request Jan 18, 2017
@JacksonTian
lib: remove unnecessary parameter for assertCrypto()
69674f4 
The `exports` parameter is unnecessary.

PR-URL: #10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
@JacksonTian @italoacasas
lib: remove unnecessary parameter for assertCrypto()
e2c4986 
The `exports` parameter is unnecessary.

PR-URL: nodejs#10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
@JacksonTian @italoacasas
lib: remove unnecessary parameter for assertCrypto()
33e7efb 
The `exports` parameter is unnecessary.

PR-URL: nodejs#10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@JacksonTian @italoacasas
lib: remove unnecessary parameter for assertCrypto()
62e92f4 
The `exports` parameter is unnecessary.

PR-URL: nodejs#10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@JacksonTian @italoacasas
lib: remove unnecessary parameter for assertCrypto()
a3abba0 
The `exports` parameter is unnecessary.

PR-URL: nodejs#10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@JacksonTian @MylesBorins
lib: remove unnecessary parameter for assertCrypto()
670e976 
The `exports` parameter is unnecessary.

PR-URL: #10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@JacksonTian @MylesBorins
lib: remove unnecessary parameter for assertCrypto()
bde1a7e 
The `exports` parameter is unnecessary.

PR-URL: #10834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <sam@strongloop.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@JacksonTian @mscdex @sam-github @jasnell @addaleax @cjihrig @MylesBorins @nodejs-github-bot