doc: mention moderation repo in onboarding doc #10869
Conversation
nodejs-github-bot
added
doc
addaleax
added
the
meta
| @@ -71,6 +71,9 @@ onboarding session. | |||
| * [**See "Who to CC in issues"**](./onboarding-extras.md#who-to-cc-in-issues) | |||
| * will also come more naturally over time | |||
|
|
|||
| * When a discussion gets heated, you can request that other collaborators keep an eye on it by opening an issue at the [nodejs/moderation](https://github.com/nodejs/moderation) repository | |||
There was a problem hiding this comment.
Super tiny nit: can you add a final dot?
addaleax
force-pushed
the
doc-onboarding-moderation
branch
from
6edc98e
to
c5fe37e
Compare
|
Might be worthwhile mentioning that the Moderation Repo details are confidential and should not be shared externally |
|
@jasnell done! |
|
I don't believe this one needs to wait the full 48 hours to land |
I’d prefer to wait, tbh… maybe other people have valid points like yours. We have one onboarding scheduled for today and @Trott can probably bring it up “manually” ;) |
|
I prefer that the wording make it more clear that the people who have access to the repository number hundreds and are not merely the collaborators team. The way it is now, someone might think it's more private than it really is. |
|
@Trott Updated, how does this wording work for you? I can include an actual number if you’d like to be even more explicit about it. |
|
@addaleax That looks good to me. Maybe this might be even a bit better?:
|
|
@Trott your phrasing works for me, too … updated :) |
|
Landed in 0c58193 |
PR-URL: #10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: nodejs#10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #10869 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
What it says in the PR title. ;)