Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add dgram.Socket.prototype.sendto's test #10901

Closed
wants to merge 1 commit into from
Closed

test: add dgram.Socket.prototype.sendto's test #10901

wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jan 19, 2017

sendto: https://github.com/nodejs/node/blob/master/lib/dgram.js#L234

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 19, 2017
cjihrig
cjihrig requested changes Jan 19, 2017
View reviewed changes
test/parallel/test-dgram-sendto.js
socket.on('listening', common.mustCall(() => {
assert.throws(() => {
socket.sendto();
}, /^Error: Send takes "offset" and "length" as args 2 and 3$/);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you store this regular expression in a variable for reuse.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@hiroppy hiroppy force-pushed the feature/add-test-dgram-sendto branch from 0dc8717 to df5c0fa Compare January 19, 2017 18:50
@mscdex mscdex added the dgram Issues and PRs related to the dgram subsystem / UDP. label Jan 19, 2017
cjihrig
cjihrig requested changes Jan 20, 2017
View reviewed changes
test/parallel/test-dgram-sendto.js
const socket = dgram.createSocket('udp4');

const errorMessage =
new RegExp(/^Error: Send takes "offset" and "length" as args 2 and 3$/);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the RegExp() constructor.

test/parallel/test-dgram-sendto.js
const errorMessage =
new RegExp(/^Error: Send takes "offset" and "length" as args 2 and 3$/);

socket.bind(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If all the sendto() calls are supposed to throw before actually sending, and we're verifying the error messages, I don't think binding, listening, and closing the socket is necessary.

@hiroppy hiroppy force-pushed the feature/add-test-dgram-sendto branch from df5c0fa to 108934d Compare January 20, 2017 01:05
@hiroppy hiroppy force-pushed the feature/add-test-dgram-sendto branch from 108934d to 8ff8f9c Compare January 20, 2017 01:08
@Trott
Copy link
Member

Trott commented Jan 20, 2017

LGTM if CI is green.

I'd leave a nit suggesting being more specific with the identifier name than just errorMessage but I'm having a hard time coming up with something significantly better that isn't probably too long, so ¯\(ツ)/¯.

@targos
Copy link
Member

targos commented Jan 22, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/5982/

Tip for the link reference you put in the commit message: You can press Y on your keyboard to get an absolute link to the current revision. That way the line will remain correct even after the file is changed on master.

@hiroppy hiroppy force-pushed the feature/add-test-dgram-sendto branch from 8ff8f9c to 5bacf6e Compare January 23, 2017 02:02
@hiroppy
Copy link
Member Author

hiroppy commented Jan 23, 2017

@targos Thanks :) I modified this commit message.

@targos
Copy link
Member

targos commented Jan 24, 2017

Landed in 320108c

@targos targos closed this Jan 24, 2017
targos pushed a commit that referenced this pull request Jan 24, 2017
@hiroppy @targos
test: add dgram.Socket.prototype.sendto's test
320108c 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: #10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
@hiroppy @italoacasas
test: add dgram.Socket.prototype.sendto's test
51945ae 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@hiroppy @italoacasas
test: add dgram.Socket.prototype.sendto's test
21eb4d6 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@hiroppy @italoacasas
test: add dgram.Socket.prototype.sendto's test
e161dcf 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@hiroppy @italoacasas
test: add dgram.Socket.prototype.sendto's test
fd016e7 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: nodejs#10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@hiroppy hiroppy deleted the feature/add-test-dgram-sendto branch February 7, 2017 00:23
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@hiroppy @MylesBorins
test: add dgram.Socket.prototype.sendto's test
4f9e4b4 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: #10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins
Copy link
Contributor

failures on v4.x, did not land

=== release test-dgram-sendto ===
Path: parallel/test-dgram-sendto
assert.js:361
    throw actual;
    ^

Error: send takes offset and length as args 2 and 3
    at Socket.sendto (dgram.js:237:11)
    at /Users/mborins/code/node/v4.x/test/parallel/test-dgram-sendto.js:11:10
    at _tryBlock (assert.js:320:5)
    at _throws (assert.js:339:12)
    at Function.assert.throws (assert.js:369:3)
    at Object.<anonymous> (/Users/mborins/code/node/v4.x/test/parallel/test-dgram-sendto.js:10:8)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@hiroppy @MylesBorins
test: add dgram.Socket.prototype.sendto's test
ed76b4a 
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234
PR-URL: #10901
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@hiroppy @Trott @targos @MylesBorins @jasnell @cjihrig @mscdex @nodejs-github-bot