Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase coverage for exec() functions #10919

Merged
merged 1 commit into from
Jan 25, 2017
Merged

test: increase coverage for exec() functions #10919

merged 1 commit into from
Jan 25, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Jan 20, 2017

This commit increases code coverage related to the stdout and stderr outputs of the child_process exec() functions. Previously, stdout was completely covered, but stderr was
not.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jan 20, 2017
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label Jan 20, 2017
Trott
Trott approved these changes Jan 20, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@santigimeno
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5969/

@cjihrig
Copy link
Contributor Author

cjihrig commented Jan 23, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/6004/

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/6006/
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/6008/
EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/6037/

mhdawson
mhdawson approved these changes Jan 23, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
test: increase coverage for exec() functions
58cb9cd 
This commit increases code coverage related to the stdout
and stderr outputs of the child_process exec() functions.
Previously, stdout was completely covered, but stderr was
not.

PR-URL: nodejs#10919
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@cjihrig cjihrig merged commit 58cb9cd into nodejs:master Jan 25, 2017
@cjihrig cjihrig deleted the encoding branch January 25, 2017 14:41
targos pushed a commit that referenced this pull request Jan 28, 2017
@cjihrig @targos
test: increase coverage for exec() functions
38e52cd 
This commit increases code coverage related to the stdout
and stderr outputs of the child_process exec() functions.
Previously, stdout was completely covered, but stderr was
not.

PR-URL: #10919
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig @italoacasas
test: increase coverage for exec() functions
1a39bfb 
This commit increases code coverage related to the stdout
and stderr outputs of the child_process exec() functions.
Previously, stdout was completely covered, but stderr was
not.

PR-URL: nodejs#10919
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@cjihrig @italoacasas
test: increase coverage for exec() functions
030a77a 
This commit increases code coverage related to the stdout
and stderr outputs of the child_process exec() functions.
Previously, stdout was completely covered, but stderr was
not.

PR-URL: nodejs#10919
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

Please open a backport PR if this should land in v4

jasnell pushed a commit that referenced this pull request Mar 8, 2017
@cjihrig @jasnell
test: increase coverage for exec() functions
418ae41 
This commit increases code coverage related to the stdout
and stderr outputs of the child_process exec() functions.
Previously, stdout was completely covered, but stderr was
not.

PR-URL: #10919
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@cjihrig @MylesBorins
test: increase coverage for exec() functions
b9615b3 
This commit increases code coverage related to the stdout
and stderr outputs of the child_process exec() functions.
Previously, stdout was completely covered, but stderr was
not.

PR-URL: #10919
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@santigimeno santigimeno santigimeno approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@sam-github sam-github sam-github approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @santigimeno @jasnell @sam-github @Trott @mhdawson @mscdex @nodejs-github-bot