benchmark: add more thorough timers benchmarks #10925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added
benchmark
nodejs-github-bot
added
benchmark
jasnell
reviewed
Jan 23, 2017
| }); | ||
|
|
||
| function main(conf) { | ||
| var N = +conf.thousands * 1e3; |
There was a problem hiding this comment.
exceedingly minor nit... why N? I tend to dislike caps for variables that aren't const
jasnell
approved these changes
Jan 23, 2017
Fishrock123
force-pushed
the
improve-timers-benchmarks
branch
from
f2ec826
to
d158547
Compare
|
ping again the rest @nodejs/benchmarking, do these look ok? |
trevnorris
approved these changes
Jan 27, 2017
Fishrock123
force-pushed
the
improve-timers-benchmarks
branch
from
d158547
to
c680d87
Compare
Refs: nodejs#9493 PR-URL: nodejs#10925 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Fishrock123
force-pushed
the
improve-timers-benchmarks
branch
from
c680d87
to
c74e6fe
Compare
|
Oops, missed a variable rename, new Lint CI: https://ci.nodejs.org/job/node-test-linter/6685/ |
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Jan 27, 2017
This was referenced Jan 27, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #9493
Adds some new benchmarks to test pooled and unpooled behavior of the insert, cancel, and timeout operations of Node timers.
This is missing an unpooled tests for timeout, since that is far more complex, and I would prefer to do it separately in all likelihood.
cc @misterdjules, @AndreasMadsen, @nodejs/benchmarking
(This patch was made live during https://www.twitch.tv/nodesource/v/117497395 if you'd like to see me working on this in retrospect. :P)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmark, timer