Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: improve compare() performance #10927

Merged
merged 1 commit into from
Jan 25, 2017
Merged

buffer: improve compare() performance #10927

merged 1 commit into from
Jan 25, 2017

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jan 20, 2017 •
edited
Loading

Here are the results of the changes in this PR, using newly added benchmark parameters:

                                                                         improvement confidence      p.value
 buffers/buffer-compare-instance-method.js millions=20 args=1 size=1024      79.64 %        *** 1.708068e-23
 buffers/buffer-compare-instance-method.js millions=20 args=1 size=16       120.23 %        *** 4.789291e-22
 buffers/buffer-compare-instance-method.js millions=20 args=1 size=16386     29.41 %        *** 6.728233e-25
 buffers/buffer-compare-instance-method.js millions=20 args=1 size=4096      38.39 %        *** 4.356356e-22
 buffers/buffer-compare-instance-method.js millions=20 args=1 size=512       95.33 %        *** 2.836086e-27
 buffers/buffer-compare-instance-method.js millions=20 args=2 size=1024      36.68 %        *** 7.725875e-16
 buffers/buffer-compare-instance-method.js millions=20 args=2 size=16        41.81 %        *** 4.501507e-12
 buffers/buffer-compare-instance-method.js millions=20 args=2 size=16386     17.62 %        *** 1.637306e-23
 buffers/buffer-compare-instance-method.js millions=20 args=2 size=4096      24.56 %        *** 1.838687e-16
 buffers/buffer-compare-instance-method.js millions=20 args=2 size=512       36.07 %        *** 1.337825e-12
 buffers/buffer-compare-instance-method.js millions=20 args=3 size=1024      26.15 %        *** 1.077808e-10
 buffers/buffer-compare-instance-method.js millions=20 args=3 size=16        38.97 %        *** 1.267865e-12
 buffers/buffer-compare-instance-method.js millions=20 args=3 size=16386     14.94 %        *** 2.809292e-22
 buffers/buffer-compare-instance-method.js millions=20 args=3 size=4096      21.77 %        *** 7.859591e-12
 buffers/buffer-compare-instance-method.js millions=20 args=3 size=512       35.13 %        *** 1.176360e-14
 buffers/buffer-compare-instance-method.js millions=20 args=4 size=1024      24.45 %        *** 6.181133e-08
 buffers/buffer-compare-instance-method.js millions=20 args=4 size=16        35.20 %        *** 5.202743e-11
 buffers/buffer-compare-instance-method.js millions=20 args=4 size=16386     15.46 %        *** 5.231296e-23
 buffers/buffer-compare-instance-method.js millions=20 args=4 size=4096      19.14 %        *** 1.193200e-09
 buffers/buffer-compare-instance-method.js millions=20 args=4 size=512       32.69 %        *** 1.456810e-14
 buffers/buffer-compare-instance-method.js millions=20 args=5 size=1024      20.11 %        *** 8.825567e-08
 buffers/buffer-compare-instance-method.js millions=20 args=5 size=16        26.04 %        *** 3.350537e-10
 buffers/buffer-compare-instance-method.js millions=20 args=5 size=16386     13.36 %        *** 2.349793e-18
 buffers/buffer-compare-instance-method.js millions=20 args=5 size=4096      19.60 %        *** 8.104786e-12
 buffers/buffer-compare-instance-method.js millions=20 args=5 size=512       22.01 %        *** 1.282699e-08

CI: https://ci.nodejs.org/job/node-test-pull-request/5971/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)
  • buffer

@mscdex mscdex added buffer Issues and PRs related to the buffer subsystem. performance Issues and PRs related to the performance of Node.js. labels Jan 20, 2017
@nodejs-github-bot nodejs-github-bot added dont-land-on-v7.x buffer Issues and PRs related to the buffer subsystem. labels Jan 20, 2017
@mscdex
buffer: improve compare() performance
9e0f6a5 
PR-URL: nodejs#10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex merged commit 9e0f6a5 into nodejs:master Jan 25, 2017
@mscdex mscdex mentioned this pull request Jan 25, 2017
Closed
@mscdex mscdex deleted the buffer-compare-perf branch January 25, 2017 06:52
targos pushed a commit that referenced this pull request Jan 28, 2017
@mscdex @targos
buffer: improve compare() performance
594ccb0 
PR-URL: #10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@mscdex @italoacasas
buffer: improve compare() performance
d13aba8 
PR-URL: nodejs#10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@mscdex @italoacasas
buffer: improve compare() performance
459a8a6 
PR-URL: nodejs#10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 8, 2017
@mscdex @jasnell
buffer: improve compare() performance
9d37abb 
PR-URL: #10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 8, 2017

This would need a backport PR if it should land on v4. Landed on v6

MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@mscdex @MylesBorins
buffer: improve compare() performance
e397e6f 
PR-URL: #10927
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
MylesBorins added a commit that referenced this pull request Mar 21, 2017
@MylesBorins
2017-03-21, Version 6.10.1 'Boron' (LTS)
e70d0b0 
Notable changes

* performance: The performance of several APIs has been improved.
  - `Buffer.compare()` is up to 35% faster on average. (Brian White)
    #10927
  - `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
    #10895
  - `fs.*statSync()` functions are now up to 9.3% faster on average.
    (Brian White) #11522
  - `os.loadavg` is up to 151% faster. (Brian White)
    #11516
  - `process.memoryUsage()` is up to 34% faster. (Brian White)
    #11497
  - `querystring.unescape()` for `Buffer`s is 15% faster on average.
    (Brian White) #10837
  - `querystring.stringify()` is up to 7.8% faster on average.
    (Brian White) #10852
  - `querystring.parse()` is up to 21% faster on average. (Brian White)
    #10874

* IPC:
  - Batched writes have been enabled for process IPC on platforms that
    support Unix Domain Sockets. (Alexey Orlenko)
    #10677
  - Performance gains may be up to 40% for some workloads.

* child_process:
  - `spawnSync` now returns a null `status` when child is terminated by
    a signal. (cjihrig) #11288
  - This fixes the behavior to act like `spawn()` does.

* http:
  - Control characters are now always rejected when using
    `http.request()`. (Ben Noordhuis)
    #8923
  - Debug messages have been added for cases when headers contain
    invalid values. (Evan Lucas)
    #9195

* node:
  - Heap statistics now support values larger than 4GB. (Ben Noordhuis)
    #10186

* timers:
  - Timer callbacks now always maintain order when interacting with
    domain error handling. (John Barboza)
    #10522

PR-URL: #11759
MylesBorins added a commit that referenced this pull request Mar 21, 2017
@MylesBorins
2017-03-21, Version 6.10.1 'Boron' (LTS)
2569c90 
Notable changes

* performance: The performance of several APIs has been improved.
  - `Buffer.compare()` is up to 35% faster on average. (Brian White)
    #10927
  - `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
    #10895
  - `fs.*statSync()` functions are now up to 9.3% faster on average.
    (Brian White) #11522
  - `os.loadavg` is up to 151% faster. (Brian White)
    #11516
  - `process.memoryUsage()` is up to 34% faster. (Brian White)
    #11497
  - `querystring.unescape()` for `Buffer`s is 15% faster on average.
    (Brian White) #10837
  - `querystring.stringify()` is up to 7.8% faster on average.
    (Brian White) #10852
  - `querystring.parse()` is up to 21% faster on average. (Brian White)
    #10874

* IPC:
  - Batched writes have been enabled for process IPC on platforms that
    support Unix Domain Sockets. (Alexey Orlenko)
    #10677
  - Performance gains may be up to 40% for some workloads.

* child_process:
  - `spawnSync` now returns a null `status` when child is terminated by
    a signal. (cjihrig) #11288
  - This fixes the behavior to act like `spawn()` does.

* http:
  - Control characters are now always rejected when using
    `http.request()`. (Ben Noordhuis)
    #8923
  - Debug messages have been added for cases when headers contain
    invalid values. (Evan Lucas)
    #9195

* node:
  - Heap statistics now support values larger than 4GB. (Ben Noordhuis)
    #10186

* timers:
  - Timer callbacks now always maintain order when interacting with
    domain error handling. (John Barboza)
    #10522

PR-URL: #11759
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
@imyller
2017-03-21, Version 6.10.1 'Boron' (LTS)
ccdb8bf 
    Notable changes

    * performance: The performance of several APIs has been improved.
      - `Buffer.compare()` is up to 35% faster on average. (Brian White)
        nodejs/node#10927
      - `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
        nodejs/node#10895
      - `fs.*statSync()` functions are now up to 9.3% faster on average.
        (Brian White) nodejs/node#11522
      - `os.loadavg` is up to 151% faster. (Brian White)
        nodejs/node#11516
      - `process.memoryUsage()` is up to 34% faster. (Brian White)
        nodejs/node#11497
      - `querystring.unescape()` for `Buffer`s is 15% faster on average.
        (Brian White) nodejs/node#10837
      - `querystring.stringify()` is up to 7.8% faster on average.
        (Brian White) nodejs/node#10852
      - `querystring.parse()` is up to 21% faster on average. (Brian White)
        nodejs/node#10874

    * IPC:
      - Batched writes have been enabled for process IPC on platforms that
        support Unix Domain Sockets. (Alexey Orlenko)
        nodejs/node#10677
      - Performance gains may be up to 40% for some workloads.

    * child_process:
      - `spawnSync` now returns a null `status` when child is terminated by
        a signal. (cjihrig) nodejs/node#11288
      - This fixes the behavior to act like `spawn()` does.

    * http:
      - Control characters are now always rejected when using
        `http.request()`. (Ben Noordhuis)
        nodejs/node#8923
      - Debug messages have been added for cases when headers contain
        invalid values. (Evan Lucas)
        nodejs/node#9195

    * node:
      - Heap statistics now support values larger than 4GB. (Ben Noordhuis)
        nodejs/node#10186

    * timers:
      - Timer callbacks now always maintain order when interacting with
        domain error handling. (John Barboza)
        nodejs/node#10522

    PR-URL: nodejs/node#11759

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
imyller added a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
@imyller
2017-03-21, Version 6.10.1 'Boron' (LTS)
e47cbbd 
    Notable changes

    * performance: The performance of several APIs has been improved.
      - `Buffer.compare()` is up to 35% faster on average. (Brian White)
        nodejs/node#10927
      - `buffer.toJSON()` is up to 2859% faster on average. (Brian White)
        nodejs/node#10895
      - `fs.*statSync()` functions are now up to 9.3% faster on average.
        (Brian White) nodejs/node#11522
      - `os.loadavg` is up to 151% faster. (Brian White)
        nodejs/node#11516
      - `process.memoryUsage()` is up to 34% faster. (Brian White)
        nodejs/node#11497
      - `querystring.unescape()` for `Buffer`s is 15% faster on average.
        (Brian White) nodejs/node#10837
      - `querystring.stringify()` is up to 7.8% faster on average.
        (Brian White) nodejs/node#10852
      - `querystring.parse()` is up to 21% faster on average. (Brian White)
        nodejs/node#10874

    * IPC:
      - Batched writes have been enabled for process IPC on platforms that
        support Unix Domain Sockets. (Alexey Orlenko)
        nodejs/node#10677
      - Performance gains may be up to 40% for some workloads.

    * child_process:
      - `spawnSync` now returns a null `status` when child is terminated by
        a signal. (cjihrig) nodejs/node#11288
      - This fixes the behavior to act like `spawn()` does.

    * http:
      - Control characters are now always rejected when using
        `http.request()`. (Ben Noordhuis)
        nodejs/node#8923
      - Debug messages have been added for cases when headers contain
        invalid values. (Evan Lucas)
        nodejs/node#9195

    * node:
      - Heap statistics now support values larger than 4GB. (Ben Noordhuis)
        nodejs/node#10186

    * timers:
      - Timer callbacks now always maintain order when interacting with
        domain error handling. (John Barboza)
        nodejs/node#10522

    PR-URL: nodejs/node#11759

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. performance Issues and PRs related to the performance of Node.js.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mscdex @jasnell @addaleax @nodejs-github-bot