Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: move trace_event.h include to internal header #10959

Merged
merged 1 commit into from
Jan 26, 2017
Merged

src: move trace_event.h include to internal header #10959

merged 1 commit into from
Jan 26, 2017

Commits on Jan 26, 2017

  1. src: move trace_event.h include to internal header 

    Move the include from src/node.h to src/node_internals.h.

trace_event.h is not shipped in binary-only and headers-only tarballs,
making it currently impossible to build add-ons against them.

PR-URL: nodejs#10959
Refs: nodejs/citgm#226 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    @bnoordhuis
    bnoordhuis committed Jan 26, 2017
    Configuration menu
    Copy the full SHA
    bfd3c7e View commit details
    Browse the repository at this point in the history