doc: for style, remove "isn't" contraction #10981
Conversation
|
@jasnell , re: #10968 (comment) |
|
I see the referenced comment, but why? |
|
@jasnell question for you ----^ I am merely the typist. Helps my markdown plugin to avoid contractions, though :-) |
|
Generally a style thing that makes reading through the docs easier, particularly for non-native English speakers. Update: bit more on this. I recommend doing a quick google search for "non-native speakers" and "avoiding contractions". Many non-native speakers do not have a problem with contractions depending on their overall level of comfort with the language. However, contractions have historically been one of the more difficult aspects of English slang/colloquialism that are difficult for non-native speakers to master. The ones that always seem least likely to cause issues are things like "it's" or "I'll" as these are far more commonly used. That said, just consider how difficult it is for most native speakers to get "it's" and "its" correct. |
|
been 3 days, two approvals, but @mscdex , did you object, or just want to know? |
|
@sam-github Not objecting, just wanted to know why. |
PR-URL: nodejs#10981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
sam-github
force-pushed
the
do-not-use-isnt
branch
from
72b1371 to
38161f0
Compare
|
Thanks @mscdex, landed in 38161f0 |
PR-URL: #10981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
landed in v6. This would need a backport PR to land in v4 |
PR-URL: #10981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #10981 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Checklist
Affected core subsystem(s)
doc