Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: DEFAULT_ECDH_CURVE was added in 0.11.13 #10983

Merged
merged 0 commits into from
Jan 25, 2017
Merged

doc: DEFAULT_ECDH_CURVE was added in 0.11.13 #10983

merged 0 commits into from
Jan 25, 2017

Conversation

sam-github
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc,tls

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem. labels Jan 24, 2017
@sam-github
Copy link
Contributor Author

@jasnell maybe I can land this right away with a couple thumbs ups?

cjihrig
cjihrig approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Landing quickly is probably fine.

@sam-github sam-github closed this Jan 25, 2017
@sam-github sam-github deleted the doc-when-ecdh-curve-added branch January 25, 2017 17:33
@sam-github sam-github merged commit 124d155 into nodejs:master Jan 25, 2017
@sam-github sam-github mentioned this pull request Jan 25, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 26, 2017
@sam-github @italoacasas
doc: DEFAULT_ECDH_CURVE was added in 0.11.13
f5c6d23 
Document this with the YAML meta-data.

PR-URL: nodejs#10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
@sam-github @italoacasas
doc: DEFAULT_ECDH_CURVE was added in 0.11.13
960af24 
Document this with the YAML meta-data.

PR-URL: nodejs#10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sam-github @italoacasas
doc: DEFAULT_ECDH_CURVE was added in 0.11.13
c4b9f0a 
Document this with the YAML meta-data.

PR-URL: nodejs#10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
@sam-github @italoacasas
doc: DEFAULT_ECDH_CURVE was added in 0.11.13
f104f9c 
Document this with the YAML meta-data.

PR-URL: nodejs#10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
@sam-github @MylesBorins
doc: DEFAULT_ECDH_CURVE was added in 0.11.13
9515cc2 
Document this with the YAML meta-data.

PR-URL: #10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@sam-github @MylesBorins
doc: DEFAULT_ECDH_CURVE was added in 0.11.13
1307104 
Document this with the YAML meta-data.

PR-URL: #10983
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sam-github @lpinca @cjihrig @gibfahn @MylesBorins @nodejs-github-bot