Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: new tls.TLSSocket() supports sec ctx options #11005

Merged
merged 2 commits into from
Feb 20, 2017
Merged

tls: new tls.TLSSocket() supports sec ctx options #11005

merged 2 commits into from
Feb 20, 2017

Commits on Feb 20, 2017

  1. test: make tls-socket-default-options tests run 

    Because of a poorly constructed test, only one of the two test vectors
ran.  The test also failed to cover the authentication error that occurs
when the server's certificate is not trusted.

Both issues are fixed.

Fix: nodejs#10538
PR-URL: nodejs#11005
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @sam-github
    sam-github committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    dc885c9 View commit details
    Browse the repository at this point in the history

  2. tls: new tls.TLSSocket() supports sec ctx options 

    Add support to new tls.TLSSocket() to create a SecureContext object with
all its supported options, in the same way they are supported for all
the other APIs that need SecureContext objects.

Fix: nodejs#10538
PR-URL: nodejs#11005
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @sam-github
    sam-github committed Feb 20, 2017
    Configuration menu
    Copy the full SHA
    ea56799 View commit details
    Browse the repository at this point in the history