Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move setImmediate benchmarks from misc/ to timers #11010

Closed
wants to merge 3 commits into from
Closed

Move setImmediate benchmarks from misc/ to timers #11010

wants to merge 3 commits into from

Conversation

joshuacolvin
Copy link
Contributor

Fixes #10926

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. lts-watch-v6.x labels Jan 26, 2017
@mscdex mscdex added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Jan 26, 2017
@fhalde
Copy link
Contributor

fhalde commented Jan 27, 2017

The commit log should have benchmark prefix. Please refer https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#step-3-commit

evanlucas
evanlucas approved these changes Jan 27, 2017
View reviewed changes
Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the commit message nit. Thanks!

@joshuacolvin
Copy link
Contributor Author

Sorry about that! So I've created another commit with the updated commit message (also had to merge remote branch). Should I squash all three together with the correct commit message?

@lpinca
Copy link
Member

lpinca commented Jan 28, 2017

@joshuacolvin that can be done when landing but if you want to help do it :)

@lpinca
Copy link
Member

lpinca commented Jan 28, 2017 •
edited
Loading

Commit title should be 50 chars or less.

benchmark: move setImmediate benchmarks to timers

should work.

Edit: or maybe not it's a bit confusing.

@jasnell
Copy link
Member

jasnell commented Jan 30, 2017

will fix the commit message on landing... landing now

jasnell pushed a commit that referenced this pull request Jan 30, 2017
@joshuacolvin @jasnell
benchmark: move setImmediate benchmarks to timers
1f342af 
PR-URL: #11010
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jan 30, 2017

Landed in 1f342af

@jasnell jasnell closed this Jan 30, 2017
@Trott Trott mentioned this pull request Jan 31, 2017
Closed
evanlucas pushed a commit that referenced this pull request Jan 31, 2017
@joshuacolvin @evanlucas
benchmark: move setImmediate benchmarks to timers
ccdc922 
PR-URL: #11010
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 31, 2017
Merged
jasnell pushed a commit that referenced this pull request Mar 7, 2017
@joshuacolvin @jasnell
benchmark: move setImmediate benchmarks to timers
ed1a5b4 
PR-URL: #11010
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
@joshuacolvin @MylesBorins
benchmark: move setImmediate benchmarks to timers
6b36161 
PR-URL: #11010
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@evanlucas evanlucas evanlucas approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joshuacolvin @fhalde @lpinca @jasnell @evanlucas @Fishrock123 @cjihrig @mscdex @nodejs-github-bot